-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dj hot fix 2 #665
Merged
Merged
Dj hot fix 2 #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter out domains that don't link to cidrs
update tests
run linter
update domain.test.ts with isFceb so tests run as normal
update all domains.create statements in tests
ameliav
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the hot fix code changes, the only failing backend tests for me were not related to this PR (API key issue). Dane to confirm if the data is exhibiting correctly after the changes.
DJensen94
requested review from
aloftus23,
cduhn17,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
October 2, 2024 19:39
schmelz21
approved these changes
Oct 2, 2024
schmelz21
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
We only want to display data for domains whose IP is directly attributable to a user provided CIDR. We only want this functionality for non-FCEB organizations.
💭 Motivation and context
This is to avoid reporting issues with IPs that belong to cloud providers and incorrectly attributed domains
🧪 Testing
I have tested locally with both in-cidr and out-cidr ips as well as on fceb and non fceb organizations
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist