Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local search #676

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fix local search #676

merged 1 commit into from
Oct 7, 2024

Conversation

jayjaybunce
Copy link
Collaborator

🗣 Description

  • Update syncdb script to account for hotfix change.

💭 Motivation and context

  • Local search endpoints were broken due to an issue introduced by a hotfix. When syncing domains, a clause was added that filtered out all domains that didn't have one of two values as true. When syncdb runs, these values aren't explicitly assigned and thus default to false, which breaks the domains sync. This fix adds a value to syncdb creating domains to ensure the value is true and the sync domains will work correctly

🧪 Testing

  1. backend => Run npm run syncdb -- -d dangerouslyforce
  2. backend => Run npm run syncdb -- -d populate
  3. Docker => Restart es-1 container
  4. Login to application and go to /inventory

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me!

Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug in develop!

@schmelz21 schmelz21 merged commit 0d845bc into develop Oct 7, 2024
15 of 18 checks passed
@schmelz21 schmelz21 deleted the fix-local-search branch October 7, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants