License Burp Suite Pro for the vnc user

[jsf9k]

🗣 Description

This pull request makes the change of licensing Burp Suite Pro for the vnc user.

💭 Motivation and Context

See cisagov/ansible-role-burp-suite-pro#5.

🧪 Testing

I built a staging AMI with this code and verified on env0 of our staging COOL environment that Burp Suite Pro is now pre-licensed.

✅ Pre-approval checklist

• This PR has an informative and human-readable title.
• Changes are limited to a single goal - eschew scope creep!
• All relevant type-of-change labels have been added.
• I have read the CONTRIBUTING document.
• These code changes follow cisagov code standards.
• All new and existing tests pass.
• Build a staging AMI
• Test staging AMI

✅ Post-approval checklist

• Revert back to the develop branch of cisagov/ansible-role-burp-suite-pro once Allow per-user licensing ansible-role-burp-suite-pro#5 is merged.
• Finalize version

✅ Post-merge checklist

• Build a production AMI

[dav3r]

Good stuff! 👍

[hillaryj]

🏆

As a point of order, should the checklist items in the PR that occur after merging go in the associated issue instead? We'd talked before about wanting all the boxes to be checked to consider a PR ready to review.

[jsf9k]

As a point of order, should the checklist items in the PR that occur after merging go in the associated issue instead? We'd talked before about wanting all the boxes to be checked to consider a PR ready to review.

I remember talking about that. The problem with putting those tasks in the associated issue is that it makes it vastly easier to forget to do them - that's why I like them being in the PR.

As an alternative, what if I created separate sections titled "Post-approval checklist" and "Post-merge checklist" and put those checkboxes there? As an example I went ahead and did that with this PR. Those sections won't normally be required, except in the case of these *-packer repos.

[dav3r]

I am good with adding these "Post-approval" and "Post-merge" checklists where needed. We could add them to the template and leave them blank with a comment asking the PR creator to add those items if necessary.

[jsf9k]

I am good with adding these "Post-approval" and "Post-merge" checklists where needed. We could add them to the template and leave them blank with a comment asking the PR creator to add those items if necessary.

We should probably rename "Checklist" to "Pre-approval checklist" in that case. I did this above as an example.

[mcdonnnj]

Glad you found the solution ✔