Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Revert to using the official isort repo #2

Closed
jsf9k opened this issue Dec 28, 2021 · 2 comments · Fixed by #1
Closed

Revert to using the official isort repo #2

jsf9k opened this issue Dec 28, 2021 · 2 comments · Fixed by #1
Labels
improvement This issue or pull request will add new or improve existing functionality

Comments

@jsf9k
Copy link
Member

jsf9k commented Dec 28, 2021

💡 Summary

We are currently being bitten by PyCQA/isort#1874. In commit 51752ee I switched to using the isort branch referenced in PyCQA/isort#1875, which was created to resolve PyCQA/isort#1874. Once PyCQA/isort#1875 is merged we should revert commit 51752ee.

Motivation and context

Once PyCQA/isort#1875 is merged the underlying branch could disappear at any moment, and in general it is better to use official sources wherever it is at all possible.
@jsf9k jsf9k added the improvement This issue or pull request will add new or improve existing functionality label Dec 28, 2021
@mcdonnnj
Copy link
Member

@jsf9k Are we good to close this per 57680bf?

@dav3r dav3r mentioned this issue Dec 30, 2021
Merged
11 tasks
@dav3r
Copy link
Member

dav3r commented Dec 30, 2021

@mcdonnnj I just added a "Resolves #2" to PR #1.

@dav3r dav3r closed this as completed in #1 Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
improvement This issue or pull request will add new or improve existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Initial commits cisagov/log4j-md-yml
3 participants
@jsf9k @dav3r @mcdonnnj