Use the latest scanner Docker image #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest scanner Docker image lengthens the pshtt timeout. Please see cisagov/domain-scan#1 for more details.
jsf9k
added
improvement
mcdonnnj
approved these changes
Dec 26, 2022
dav3r
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the Docker composition to use the latest Docker image from cisagov/scanner.
💭 Motivation and context
The latest version of this Docker image contains a change that lengthens the
pshtttimeout. See cisagov/domain-scan#1 for more details.🧪 Testing
All automated testing passes. I also did a full production run with this new Docker image this weekend and everything appears to have worked as expected.
✅ Pre-approval checklist
✅ Post-merge checklist