Pin sslyze to v2.x #211
Merged
Pin sslyze to v2.x #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking care of this @cablej! I'll take a look at the failing build tonight or tomorrow morning. |
|
Thanks for your contribution @cablej ! I believe the error in the Travis build can be resolved by changing Line 23 in 43dcd58 to pip install --upgrade flake8 pytest-cov pytest coveralls. It appears that there's an older version of pytest on the Travis instance that is incompatible with newer versions of pytest-cov, and that breaks the pytest run.
|
|
I made @mcdonnnj's suggested change, but now there is another problem where it can't find a suitable wheel for the nassl package. I will revisit this in the morning. |
Python 3.8 appears to require manylinux2010 wheels, while 3.7 can use manylinux1 wheels. Now that sslyze is pinned, the version of nassl that must be installed is 2.2.0, and that is only available on pypi.org as a manylinux1 wheel.
The image used by the Dockerfile is pulling down a 3.8+ image. The version of nassl we are trying to install is only compatible on Python 3.7.
|
I'll temporarily turn off the TravisCI Branch check in order to merge this once there are enough reviews in place. |
chigby
added a commit
to freedomofpress/securethenews
that referenced
this pull request
Jul 13, 2020
This change is needed before we can install software on the containers running python 3.7 I'm not exactly sure why libpq-dev was needed, but the pip-tools commands wouldn't work until I installed it. It was saying that `pg_config` was needed. Something to do with psycopg2? It's also possible there are version problems with pshtt (again). The latest version, 0.6.7, will not compile under pip-tools because it has conflicting requirements with itself: ``` There are incompatible versions in the resolved dependencies: cryptography>=2.8 (from pyopenssl==19.1.0->pshtt==0.6.7->-r requirements.in (line 13)) cryptography==2.5 (from sslyze==2.1.4->pshtt==0.6.7->-r requirements.in (line 13)) ``` So I installed the most recent version that successfully compiles. It's possible there are bugs? See cisagov/pshtt#211 for more information.
chigby
added a commit
to freedomofpress/securethenews
that referenced
this pull request
Jul 22, 2020
This change is needed before we can install software on the containers running python 3.7 I'm not exactly sure why libpq-dev was needed, but the pip-tools commands wouldn't work until I installed it. It was saying that `pg_config` was needed. Something to do with psycopg2? It's also possible there are version problems with pshtt (again). The latest version, 0.6.7, will not compile under pip-tools because it has conflicting requirements with itself: ``` There are incompatible versions in the resolved dependencies: cryptography>=2.8 (from pyopenssl==19.1.0->pshtt==0.6.7->-r requirements.in (line 13)) cryptography==2.5 (from sslyze==2.1.4->pshtt==0.6.7->-r requirements.in (line 13)) ``` So I installed the most recent version that successfully compiles. It's possible there are bugs? See cisagov/pshtt#211 for more information.
chigby
added a commit
to freedomofpress/securethenews
that referenced
this pull request
Jul 22, 2020
This change is needed before we can install software on the containers running python 3.7 I'm not exactly sure why libpq-dev was needed, but the pip-tools commands wouldn't work until I installed it. It was saying that `pg_config` was needed. Something to do with psycopg2? It's also possible there are version problems with pshtt (again). The latest version, 0.6.7, will not compile under pip-tools because it has conflicting requirements with itself: ``` There are incompatible versions in the resolved dependencies: cryptography>=2.8 (from pyopenssl==19.1.0->pshtt==0.6.7->-r requirements.in (line 13)) cryptography==2.5 (from sslyze==2.1.4->pshtt==0.6.7->-r requirements.in (line 13)) ``` So I installed the most recent version that successfully compiles. It's possible there are bugs? See cisagov/pshtt#211 for more information.
chigby
added a commit
to freedomofpress/securethenews
that referenced
this pull request
Jul 27, 2020
This change is needed before we can install software on the containers running python 3.7 I'm not exactly sure why libpq-dev was needed, but the pip-tools commands wouldn't work until I installed it. It was saying that `pg_config` was needed. Something to do with psycopg2? It's also possible there are version problems with pshtt (again). The latest version, 0.6.7, will not compile under pip-tools because it has conflicting requirements with itself: ``` There are incompatible versions in the resolved dependencies: cryptography>=2.8 (from pyopenssl==19.1.0->pshtt==0.6.7->-r requirements.in (line 13)) cryptography==2.5 (from sslyze==2.1.4->pshtt==0.6.7->-r requirements.in (line 13)) ``` So I installed the most recent version that successfully compiles. It's possible there are bugs? See cisagov/pshtt#211 for more information.
harrislapiroff
pushed a commit
to freedomofpress/securethenews
that referenced
this pull request
Aug 3, 2020
This change is needed before we can install software on the containers running python 3.7 I'm not exactly sure why libpq-dev was needed, but the pip-tools commands wouldn't work until I installed it. It was saying that `pg_config` was needed. Something to do with psycopg2? It's also possible there are version problems with pshtt (again). The latest version, 0.6.7, will not compile under pip-tools because it has conflicting requirements with itself: ``` There are incompatible versions in the resolved dependencies: cryptography>=2.8 (from pyopenssl==19.1.0->pshtt==0.6.7->-r requirements.in (line 13)) cryptography==2.5 (from sslyze==2.1.4->pshtt==0.6.7->-r requirements.in (line 13)) ``` So I installed the most recent version that successfully compiles. It's possible there are bugs? See cisagov/pshtt#211 for more information.
harrislapiroff
pushed a commit
to freedomofpress/securethenews
that referenced
this pull request
Aug 3, 2020
This change is needed before we can install software on the containers running python 3.7 I'm not exactly sure why libpq-dev was needed, but the pip-tools commands wouldn't work until I installed it. It was saying that `pg_config` was needed. Something to do with psycopg2? It's also possible there are version problems with pshtt (again). The latest version, 0.6.7, will not compile under pip-tools because it has conflicting requirements with itself: ``` There are incompatible versions in the resolved dependencies: cryptography>=2.8 (from pyopenssl==19.1.0->pshtt==0.6.7->-r requirements.in (line 13)) cryptography==2.5 (from sslyze==2.1.4->pshtt==0.6.7->-r requirements.in (line 13)) ``` So I installed the most recent version that successfully compiles. It's possible there are bugs? See cisagov/pshtt#211 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several issues have been reported due to breaking changes in sslyze's latest versions (#210, #209). This PR takes the same strategy of domain-scan in pinning sslyze to under v3 in order to retain functionality.