Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct quotes in shell script #70

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Correct quotes in shell script #70

merged 3 commits into from
Dec 6, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 6, 2022

🗣 Description

This pull request corrects an issue around the use of quotes in a shell script.

💭 Motivation and context

The code as it was previously is incorrect.

🧪 Testing

All automated tests pass. I will perform a full test of these changes this weekend when I handle the BOD 18-01 reports.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

The quotes were wrapping {pshtt,trustymail}, which forced the braces
to be interpreted as literals.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number labels Dec 6, 2022
@jsf9k jsf9k self-assigned this Dec 6, 2022
@jsf9k jsf9k marked this pull request as ready for review December 6, 2022 15:37
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I have a request around consistency for your consideration.

src/scan.sh Outdated Show resolved Hide resolved
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jsf9k jsf9k merged commit 26e1825 into develop Dec 6, 2022
@jsf9k jsf9k deleted the bugfix/correct-quotes branch December 6, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality version bump This issue or pull request increments the version number
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants