Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a test case for report gen #56

Merged
merged 11 commits into from
Sep 29, 2023
Merged

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Sep 28, 2023

🗣 Description

This PR resolves issue #26 and creates a test case for the report_gen function in report_generator.py.

💭 Motivation and context

This will add a test case to an untested function and give more coverage.

🧪 Testing

All automated tests, including this new test, were successful.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav changed the title Issue 26/create test report gen Create a test case for report gen Sep 28, 2023
@ameliav ameliav self-assigned this Sep 29, 2023
@ameliav ameliav added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Sep 29, 2023
@ameliav ameliav linked an issue Sep 29, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Sep 29, 2023

Pull Request Test Coverage Report for Build 6356596636

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 6327964742: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@ameliav ameliav marked this pull request as ready for review September 29, 2023 13:45
@ameliav ameliav requested review from jsf9k and dav3r September 29, 2023 13:46
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of small changes to request.

tests/test_report_generator.py Outdated Show resolved Hide resolved
tests/test_report_generator.py Outdated Show resolved Hide resolved
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@ameliav ameliav merged commit 73b9b59 into develop Sep 29, 2023
43 checks passed
@ameliav ameliav deleted the issue-26/create_test_report_gen branch September 29, 2023 21:16
@dav3r dav3r mentioned this pull request Oct 11, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create tests/test_report_generator.py test_report_gen()
4 participants