Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout for conclusion section in report_generator.py #75

Merged

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Dec 11, 2023

🗣 Description

Update layout for conclusion section in report_generator.py

💭 Motivation and context

Ensure that the conclusion section's header will not be separated by a line break from its content.

🧪 Testing

Ran the report multiple times to ensure the conclusion pieces would not break apart on separate pages.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@ameliav ameliav self-assigned this Dec 11, 2023
@ameliav ameliav linked an issue Dec 11, 2023 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Dec 11, 2023

Pull Request Test Coverage Report for Build 7183728488

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 7145365496: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

@ameliav ameliav marked this pull request as ready for review December 11, 2023 19:37
Copy link
Collaborator

@nickviola nickviola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

Copy link
Contributor

@JCantu248 JCantu248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ameliav ameliav merged commit 304dc8a into develop Dec 12, 2023
44 checks passed
@ameliav ameliav deleted the 71-conclusionrecommendation-title-stays-on-previous-page branch December 12, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conclusion/Recommendation title stays on previous page
4 participants