Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax errors #20

Closed
wants to merge 1 commit into from
Closed

Fix syntax errors #20

wants to merge 1 commit into from

Conversation

SuperQ
Copy link

@SuperQ SuperQ commented Feb 13, 2023

Fix various syntax errors in v2/AIRESPACE-WIRELESS-MIB.my

Fixes: #19

Signed-off-by: SuperQ superq@gmail.com

@SuperQ
Copy link
Author

SuperQ commented Feb 13, 2023

👓 @kyzer-davis

@SuperQ
Copy link
Author

SuperQ commented Feb 13, 2023

Validated this no longer produces level 1 errors with smilint.

 $ smilint -p v2/AIRESPACE-REF-MIB.my -l 1 v2/AIRESPACE-WIRELESS-MIB.my
v2/AIRESPACE-WIRELESS-MIB.my:1897: syntax error, unexpected NUMBER, expecting LOWERCASE_IDENTIFIER
v2/AIRESPACE-WIRELESS-MIB.my:2189: syntax error, unexpected MAX_ACCESS
v2/AIRESPACE-WIRELESS-MIB.my:4477: syntax error, unexpected UPPERCASE_IDENTIFIER, expecting LOWERCASE_IDENTIFIER
v2/AIRESPACE-WIRELESS-MIB.my:4485: syntax error, unexpected MAX_ACCESS
v2/AIRESPACE-WIRELESS-MIB.my:9728: identifier `bsnGlobalDot11aRxSopThreshold' registers object identifier already registered by `bsnGlobalDot11b80211eMaxBandwidth'
v2/AIRESPACE-WIRELESS-MIB.my:10580: identifier `bsnRrmDot11bSignalTimeoutFactor' registers object identifier already registered by `bsnRrmDot11aSignalTimeoutFactor'
v2/AIRESPACE-WIRELESS-MIB.my:13961: syntax error, unexpected NUMBER, expecting LOWERCASE_IDENTIFIER
v2/AIRESPACE-WIRELESS-MIB.my:14254: syntax error, unexpected MAX_ACCESS
v2/AIRESPACE-WIRELESS-MIB.my:1726: unknown object identifier label `bsnMobileStationReasonCode'
v2/AIRESPACE-WIRELESS-MIB.my:4185: unknown object identifier label `bsnAPType'
v2/AIRESPACE-WIRELESS-MIB.my:12611: unknown object identifier label `bsnStationReasonCode'

@SuperQ SuperQ mentioned this pull request Feb 13, 2023
Merged
@SuperQ
Fix syntax errors
9906ae7 
Fix various syntax errors in `v2/AIRESPACE-WIRELESS-MIB.my`

Fixes: cisco#19

Signed-off-by: SuperQ <superq@gmail.com>
@kyzer-davis
Copy link
Contributor

Thanks @SuperQ, let me have Vijay take a look at this and approve since he worked on #12

@SuperQ
Copy link
Author

SuperQ commented Apr 6, 2023

Ping @vijaygu2

@kyzer-davis
Copy link
Contributor

@SuperQ, I discussed with Vijay yesterday and the Cisco Wireless Team who owns these MIBs is addressing the issue internally then will share the new files for me to post here.

@SuperQ
Copy link
Author

SuperQ commented Apr 13, 2023

Ok, hopefully they fix it. For now we have pinned our use to the old version that still works.

@SuperQ SuperQ closed this Apr 13, 2023
hanazuki added a commit to ruby-no-kai/rubykaigi-net that referenced this pull request Apr 15, 2023
@hanazuki
docker/snmp-exporter-config-generator: Update generator and install m…
1bea12c 
…issing MIBs from cisco repo

Note that the current version of cisco/cisco-mibs is broken.
See cisco/cisco-mibs#20 (comment)
sorah pushed a commit to ruby-no-kai/rubykaigi-net-apps that referenced this pull request Dec 7, 2023
@hanazuki
docker/snmp-exporter-config-generator: Update generator and install m…
85d130f 
…issing MIBs from cisco repo

Note that the current version of cisco/cisco-mibs is broken.
See cisco/cisco-mibs#20 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswarbrick dswarbrick dswarbrick left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSCwi58728 - Syntax Issues in AIRESPACE-WIRELESS-MIB.my
3 participants
@SuperQ @kyzer-davis @dswarbrick