Bump the API version to add support for new requirements from Firefox. #3648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also lets us access multi-threaded decoding and enabling logging. |
|
We updated the gmp-api repository which should resolve the build issues: |
|
Made a small change to the build system to add "-std=c++17" for OSX builds to make it compatible with our GMP API |
aosmond
force-pushed
the
ao_bug1827703
branch
2 times, most recently
from
1ffb7b2
to
ec68dcf
Compare
|
When you merge this, could you please cherry pick this onto 2.3.1 to release 2.3.2? |
|
Or whatever version bump this change would merit. |
Export the updated presentation timestamp from the decoder. This resolves frame jank in Firefox with B frames by displaying frames in order, without being dropped due to being too old for display. Implement Reset to flush pending frames from the decoder. This resolves seeking in Firefox with the updated presentation timestamps, where old frames would get processed and interfere with the seek. Expose more options for encoding so that we can potentially implement a generic GMP video encoder wrapper.
GuangweiWang
pushed a commit
that referenced
this pull request
Apr 27, 2023
#3648) Export the updated presentation timestamp from the decoder. This resolves frame jank in Firefox with B frames by displaying frames in order, without being dropped due to being too old for display. Implement Reset to flush pending frames from the decoder. This resolves seeking in Firefox with the updated presentation timestamps, where old frames would get processed and interfere with the seek. Expose more options for encoding so that we can potentially implement a generic GMP video encoder wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the updated presentation timestamp from the decoder. This resolves frame jank in Firefox with B frames by displaying frames in order, without being dropped due to being too old for display.
Implement Reset to flush pending frames from the decoder. This resolves seeking in Firefox with the updated presentation timestamps, where old frames would get processed and interfere with the seek.