Fix frame-decode errors. #3723
Merged
Fix frame-decode errors. #3723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@BenzhengZhang ping? |
|
@tyan0 Is there a risk of regression? |
|
I cannot say that there is never a risk of regression, however, as far as I tested (with many of my video archives and the test cases of which recently reported) I have not found any regression so far. |
At this point I guess it would be best to merge it to master to find out. |
|
Fixed a bug reported in #3772 |
... and fix trivial issue of that function. This solves the some frame decode error.
This fixes the fuzzing test failure. Addresses: cisco#3772
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** This PR is re-submission of PR (#3721) to fix rebase issue. **
This pull request is for both #3710 and #3713.
I am not very sure that these are the correct fixes even though the frame decode errors are indeed resolved, so please review them. Especially for #3713.