-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement augment.gender
#43
Implement augment.gender
#43
Conversation
5b00faa
to
cc1ac74
Compare
cc1ac74
to
f98941b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice!!
Made a few comments, will take another look after the pyright error is resolved.
…mplement-en-gender
…a/langcheck into implement-en-gender
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!!
I tried running the code and left one comment about nltk
download.
I also found a small bug. When there are more than one sentence or the sentence has an extra space in the last, the space is handled weirdly. Could you investigate the reasons?
>>> langcheck.augment.en.gender("Actually she was a fish. Noooo")
['Actually they was a fish . Noooo']
>>> langcheck.augment.en.gender("Actually she was a fish. ")
['Actually they was a fish.']
Tell me once the small bug I mentioned here is also fixed!! |
Thanks for the investigation!! In that case, it should be a lot of work to fix the problem and I don't think it's worth it. As you mentioned,
After these issues are made and the conflicts are resolved, I'll approve this PR! |
…mplement-en-gender
@liwii I opened the two issues I remarked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!!
Motivation
Implement
augment.gender