Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOT FIX] Pin openai<1.0.0 #44

Merged

Conversation

Alnusjaponica
Copy link
Contributor

@Alnusjaponica Alnusjaponica commented Nov 8, 2023

Motivation

Some breaking changes are introduced by the major update of opneai, which currently prevents irrelevant PR from merging. This PR pins the version to temporary resolve the CI failure.

@Alnusjaponica Alnusjaponica marked this pull request as ready for review November 8, 2023 06:49
@Alnusjaponica Alnusjaponica changed the title Pin openai<1.0.0 [HOT FIX] Pin openai<1.0.0 Nov 8, 2023
@Alnusjaponica
Copy link
Contributor Author

Sees like there are automated migration tools. See openai/openai-python#631 and Alnusjaponica#1

@kennysong
Copy link
Contributor

Yosuke should probably review this before the next release.

It looks like they deprecated Azure API support in openai 1.0.0 so the migration will be non-trivial.

@yosukehigashi
Copy link
Contributor

Testing now!

Copy link
Contributor

@yosukehigashi yosukehigashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching!

@yosukehigashi
Copy link
Contributor

Yosuke should probably review this before the next release.

It looks like they deprecated Azure API support in openai 1.0.0 so the migration will be non-trivial.

Yeah there's quite a lot that changed it seems. Pinning openai<1 works for now!

@yosukehigashi
Copy link
Contributor

I'll merge this first, since tests for #45 won't pass otherwise. Thanks @Alnusjaponica for the fix!

@yosukehigashi yosukehigashi merged commit 061c9d7 into citadel-ai:main Nov 8, 2023
2 checks passed
@Alnusjaponica Alnusjaponica deleted the hotfix/pin-openai-version branch November 8, 2023 08:38
@yosukehigashi yosukehigashi mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants