Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(voip/mumble): Add MUMBLE_DOES_CHANNEL_EXIST native #2682

Merged

Conversation

niekschoemaker
Copy link
Contributor

Goal of this PR

To add the ability to check if channels exist, which is usefull to avoid issue #2677

Additionally changed the insert call for channels to emplace (same way as done in users) and cache the widened channel name before a for loop where this was not done yet.

How is this PR achieving the goal

It adds the native MUMBLE_DOES_CHANNEL_EXIST which allows scripts to check if a mumble channel exists before executing a native on said channel ensuring that the native actually has effect.

This PR applies to the following area(s)

FiveM & RedM (voip/mumble)

Successfully tested on

Game builds: 9073

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

fixes #2677

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Jul 29, 2024
@niekschoemaker niekschoemaker changed the title feature(voip/mumble): Add MUMBLE_DOES_CHANNEL_EXIST native feat(voip/mumble): Add MUMBLE_DOES_CHANNEL_EXIST native Jul 31, 2024
@niekschoemaker
Copy link
Contributor Author

Force pushed to fix commit title from feature to feat

@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Jul 31, 2024
Copy link
Contributor

@FabianTerhorst FabianTerhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@FabianTerhorst FabianTerhorst added ready-to-merge This PR is enqueued for merging and removed triage Needs a preliminary assessment to determine the urgency and required action labels Aug 18, 2024
@prikolium-cfx prikolium-cfx merged commit 9cb2e86 into citizenfx:master Aug 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Voice Targets not applied when channel doesn't exist
5 participants