-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ext/cfx-ui): South Korea system locale #2755
Conversation
When can I get my review? |
Hi. I've reviewed your PR yesterday. Please see the comment above. After you resolve it - we can do the merge. The PR overall looks good. |
Oh, sorry, my bad, I forgot to send it :). Thank you for the ping! Sent now. |
895d112
to
7bdecd7
Compare
The change looks good, but now there are two "fix(ext/cfx-ui): South Korea system locale" commits. One for the original change and one for the comment fix. Please squash them with as suggested by #2745 (comment) . But you need to squash two commits instead of one this time:
|
Looks good now. Thank you for the change. And sorry again for a bit of a messy review :). Its my bad. |
Goal of this PR
Clarify the South Korea server
How is this PR achieving the goal
Currently, the South Korea server is not displayed on the home screen. If the country is ko-KO, please set it to ko-KR to resolve this issue.
This PR applies to the following area(s)
FiveM, RedM
Successfully tested on
Game builds: ALL
Platforms: Windows
Checklist