Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateMissionTrain: Fix Double metro train variation #915

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Z3rio
Copy link
Contributor

@Z3rio Z3rio commented Sep 3, 2023

This PR aims to resolve issue #910.

The issue refers to the train variant Double metro train, who's number has been changed from 25 to 26.
Please note that this PR is only based off of the info in the issue, it has not been tested in-game yet, so please refrain from merging before it has actually been verified that such change is correct.

@Z3rio Z3rio changed the title Fix train cart variation CreateMissionTrain: Fix Double metro train variation Sep 3, 2023
Copy link
Contributor

@4mmonium 4mmonium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems correct, thank you for your contribution. I tested 2802 using fxDK and given the code example provided in this native, it indeed seems that there's a new train variation, thus causing the metro variation to shift from id 25 to 26 in 2802.

@thorium-cfx thorium-cfx merged commit 4a1da2a into citizenfx:master Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants