lists/ir.csv: fix handle link #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was supposed to be testing resolution of the hdl.handle.net do- main itself, not what the Handle link resolves to (Handles are like DOIs, where a persistent identifier points to a resource on another domain). We had a case of hdl.handle.net being blocked in Iran (not sure if still the case). This test was erroneously updated to point to the resolved resource (I suspect someone used a script to update the list, because the Handle service would have returned an HTTP redirect). Furthermore, a trailing slash on this URL is not even valid (returns HTTP 404). See: citizenlab#323 See: 34cac1b
|
Thank you @alanorth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was supposed to be testing resolution of the hdl.handle.net domain itself, not what the Handle link resolves to (Handles are like DOIs, where a persistent identifier points to a resource on another domain). We had a case of hdl.handle.net being blocked in Iran (not sure if still the case).
This test was erroneously updated to point to the resolved resource (I suspect someone used a script to update the list, because the Handle service would have returned an HTTP redirect). Furthermore, a trailing slash on this URL is not even valid (returns HTTP 404).
See: #323
See: 34cac1b