Rc 1.4.1 #234
Merged
Rc 1.4.1 #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elliot-sabitov
commented
Aug 16, 2024
elliot-sabitov
commented
- (Release 1.4) Adding retry setup support for sequelize #194 - (Release 1.4) Adding retry setup support for sequelize
- (Release 1.4) Enhancing Boot Notification Service/Handler tests #223 - (Release 1.4) Enhancing Boot Notification Service/Handler tests
- [Cost updated] Improve accuracy of cost calculations #219 - [Cost updated] Improve accuracy of cost calculations
…for async setup for the server
…ance cost updated flow to preserve precision; add tests
…ls in Configuration module
…structor to take in a cache + logger to support some of the boot notification handler functionality that was moved into the service
…lity out of Configuration module's BootNotification handler to BootNotificationService + DeviceModelService to prepare for unit tests
…icationService's "cacheChargerActionsPermissions" method
…icationService's "triggerGetBaseReport" method
…d code in DeviceModelService
…ootNotificationService test
…ger set variables if pendingBootSetVariables.length > 0, rather than > 1
…able from bootWithRejectedVariables to doNotBootWithRejectedVariables for clarity
…ablesActionsAfterBoot to executeSetVariablesAfterBoot for brevity
…et variables since it's not as easy to do as initially thought
…om DeviceModelService
… as a constructor argument for BootNotificationService and instead passing it in to the relevant methods that need it + moving more cache-related calls back into the module since they're not relevant to the methods they were put into
… as a constructor argument from remaining files + adding more comments
…clear variable monitoring handler logic into service
…est script + adding unit tests for processClearMonitoringResult
…port Signed-off-by: thanaParis <83840862+thanaParis@users.noreply.github.com>
…port * rc-1.4.0: (68 commits) fix: run only install for jest tests to avoid workspaces as they aren't needed fix: add run build for finding lower packages. fix: also make sure parent level dependancies are installed. fix: run install all with workspace and bump npm cache version to get away from EOL node version alert feat: add github action to run npm test refactor: Standardize naming convention with suffix `Provider` and capitalcase filenames for tests fix: resolving this.readNextId undefined error signed meter values: running linter signed meter values: separating validation into distinct blocks to log exactly what makes the signature invalid signed meter values: simplifying logic in validateMeterValues signed meter values: removing device model repository as a dependency for SignedMeterValuesUtil chore: remove unused signed meter values: simplifying logic for validateMeterValues to remove check for PublicKeyWithSignedMeterValue since we'd rather validate as we see signed meter values rather than shortcut + running linter signed meter values: for consistency, updating all validation methods in SignedMeterValuesUtil to be "validate..." rather than "is...Valid" signed meter values: updating signingMethod enum in signedMeterValuesConfiguration with the correct signing method ECDSA signed meter values: simplifying meter values shortcut by just returning false signed meter values: moving RSA validation into a helper method for readability + running linter signed meter values: removing privateKeyFileId from the config since it's not used signed meter values: shortcut meter values validation as soon as any of the sampled values are not valid signed meter values: running linter ...
…cation-service-tests # Conflicts: # 03_Modules/Configuration/test/module/BootNotificationService.test.ts
…-async-support (Release 1.4) Adding retry setup support for sequelize
* rc-1.4.0: (106 commits) chore: resolving build error fix: run only install for jest tests to avoid workspaces as they aren't needed fix: add run build for finding lower packages. fix: also make sure parent level dependancies are installed. fix: run install all with workspace and bump npm cache version to get away from EOL node version alert feat: add github action to run npm test refactor: Standardize naming convention with suffix `Provider` and capitalcase filenames for tests fix: resolving this.readNextId undefined error chore: ensuring node_modules is ignored chore: removing ajv from swarm and setting new version in base chore: fixing ajv conflicts chore: updating eslint / tslint setup to newer version and removing no longer supported files but instead using the new eslint.config.js following all recommended settings overriding only the no-explicit-any and no-unused-vars values and setting the ignores ocpi-reservation: changes based on feedback chore: reversting linting changes chore: adjusting all dependency versions to be static where possible, in a single case, "@fastify/swagger-ui": "1.9.3", enforces us to use "@fastify/swagger": "^8.0.0". Making versions static because in OCPI the latest renovate changes that made all of the dependencies static now introduce a lot of conflicts in any overlapping dependencies that in core still contain the carrot ^ fix: resoling issue with Ajv version conflicts as it is used in a few other libraries and to make sure that we are using it as intended by moving to base and exporting from there to be imported into other modules from base instead of ajv directly ensuring the correct version is applied. chore: fixing fastify swagger.ts build error, also seemingly version related, by wrapping in "as any" which works chore: aligning @typescript-eslint/eslint-plugin version Revert "chore: simplifying lint commands" chore: simplifying lint commands fix: issue with Ajv conflicting with the version that fastify is bringing by overriding in package.json and ensuring that we are importing it correctly to resolve type error chore: removing --workspaces to ensure that all dev dependencies are installed along with the workspace dependencies otherwise some dependencies are missed. ... # Conflicts: # 00_Base/package.json # 00_Base/src/index.ts
…ation-service-tests (Release 1.4) Enhancing Boot Notification Service/Handler tests
…ing-tests (Release 1.4) Clear Variable Monitoring handler unit tests
* rc-1.4.0: (24 commits) enhancing boot notification service tests: removing unnecessary added awaits clear variable monitoring tests: fixing import in unit test to use the correct path clear variable monitoring tests: simplifying imports in Monitoring module clear variable monitoring tests: adding jest config to package json test script + adding unit tests for processClearMonitoringResult clear variable monitoring tests: adding base for MonitoringService test clear variable monitoring tests: adding MonitoringService and moving clear variable monitoring handler logic into service enhancing boot notification service tests: removing maxCachingSeconds as a constructor argument from remaining files + adding more comments enhancing boot notification service tests: removing maxCachingSeconds as a constructor argument for BootNotificationService and instead passing it in to the relevant methods that need it + moving more cache-related calls back into the module since they're not relevant to the methods they were put into enhancing boot notification service tests: removing unused imports from DeviceModelService enhancing boot notification service tests: reverting pulling out of set variables since it's not as easy to do as initially thought enhancing boot notification service tests: undoing some condition simplifications enhancing boot notification service tests: rename from executeSetVariablesActionsAfterBoot to executeSetVariablesAfterBoot for brevity enhancing boot notification service tests: fixing name of helper variable from bootWithRejectedVariables to doNotBootWithRejectedVariables for clarity enhancing boot notification service tests: updating condition to trigger set variables if pendingBootSetVariables.length > 0, rather than > 1 enhancing boot notification service tests: fixing build issues with BootNotificationService test enhancing boot notification service tests: removing unneeded commented code in DeviceModelService enhancing boot notification service tests: adding tests for BootNotificationService's "triggerGetBaseReport" method enhancing boot notification service tests: adding tests for BootNotificationService's "cacheChargerActionsPermissions" method enhancing boot notification service tests: refactoring more functionality out of Configuration module's BootNotification handler to BootNotificationService + DeviceModelService to prepare for unit tests enhancing boot notification service tests: updating boot servivce constructor to take in a cache + logger to support some of the boot notification handler functionality that was moved into the service ...
[Cost updated] Improve accuracy of cost calculations
|
The ws connection seems hang up. I run |
Found the issue which was caused by deasync being used in a promise which resulted in the hanging behavior during startup. PR with fix #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.