-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rightComparisionLimit value in columnar_tableam #7543
Labels
Comments
Yeah, that seems like a copy paste mistake. Do you want to submit a PR to fix that? If not, one of us will probably pick it up soon-ish. |
To be clear, in practice this issue shouldn't be hit. Since our of the columnar extension are always of the form XY.Z, so length 4. |
JelteF
pushed a commit
that referenced
this issue
Apr 16, 2024
JelteF
pushed a commit
that referenced
this issue
Apr 16, 2024
JelteF
pushed a commit
that referenced
this issue
Apr 16, 2024
JelteF
pushed a commit
that referenced
this issue
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Have noticed that rightComparisonLimit is the same size as left:
citus/src/backend/columnar/columnar_tableam.c
Line 2949 in f424268
Is it correct?
Maybe it should be:
rightComparisionLimit = strlen(rightVersion);
The text was updated successfully, but these errors were encountered: