Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rightComparisionLimit value in columnar_tableam #7543

Closed
sminux opened this issue Feb 27, 2024 · 2 comments
Closed

rightComparisionLimit value in columnar_tableam #7543

sminux opened this issue Feb 27, 2024 · 2 comments

Comments

@sminux
Copy link
Contributor

sminux commented Feb 27, 2024

Have noticed that rightComparisonLimit is the same size as left:

rightComparisionLimit = strlen(leftVersion);

Is it correct?
Maybe it should be:
rightComparisionLimit = strlen(rightVersion);

@JelteF
Copy link
Contributor

JelteF commented Mar 3, 2024

Yeah, that seems like a copy paste mistake. Do you want to submit a PR to fix that? If not, one of us will probably pick it up soon-ish.

@JelteF
Copy link
Contributor

JelteF commented Mar 3, 2024

To be clear, in practice this issue shouldn't be hit. Since our of the columnar extension are always of the form XY.Z, so length 4.

JelteF pushed a commit that referenced this issue Mar 5, 2024
emelsimsek pushed a commit that referenced this issue Mar 11, 2024
JelteF pushed a commit that referenced this issue Apr 16, 2024
DESCRIPTION: change for #7543
(cherry picked from commit d59c93b)
JelteF pushed a commit that referenced this issue Apr 16, 2024
DESCRIPTION: change for #7543
(cherry picked from commit d59c93b)
JelteF pushed a commit that referenced this issue Apr 16, 2024
DESCRIPTION: change for #7543
(cherry picked from commit d59c93b)
JelteF pushed a commit that referenced this issue Apr 17, 2024
DESCRIPTION: change for #7543
(cherry picked from commit d59c93b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants