Support EXPLAIN ANALYZE EXECUTE and EXPLAIN EXECUTE #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4068 +/- ##
==========================================
+ Coverage 90.69% 90.73% +0.03%
==========================================
Files 186 186
Lines 35762 35804 +42
==========================================
+ Hits 32436 32486 +50
+ Misses 3326 3318 -8 |
pykello
force-pushed
the
explain_analyze_execute
branch
from
1fe56ff
to
306de49
Compare
pykello
force-pushed
the
explain_analyze_execute
branch
3 times, most recently
from
cab0edf
to
5634d3a
Compare
pykello
changed the title
pykello
force-pushed
the
explain_analyze_execute
branch
7 times, most recently
from
c145f5e
to
cb61b40
Compare
pykello
force-pushed
the
explain_analyze_execute
branch
from
cb61b40
to
c04aabb
Compare
pykello
changed the title
marcocitus
reviewed
Jul 28, 2020
| /* | ||
| * ExecutorBoundParams returns the bound parameters of the current ongoing call | ||
| * to ExecutorRun. This is meant to be used by UDFs which need to access bound | ||
| * parameters. |
There was a problem hiding this comment.
what happens when a PL/pgSQL UDF calls other PL/pgSQL UDFs? We'd be in multiple levels of ExecutorRun. Could we lose the executorBoundParams?
There was a problem hiding this comment.
Fixed & added a test which would fail if this is not handled properly.
marcocitus
reviewed
Jul 28, 2020
pykello
force-pushed
the
explain_analyze_execute
branch
2 times, most recently
from
b34e3be
to
027e858
Compare
marcocitus
reviewed
Jul 31, 2020
| @@ -128,6 +134,9 @@ CitusExecutorRun(QueryDesc *queryDesc, | |||
| { | |||
| DestReceiver *dest = queryDesc->dest; | |||
|
|
|||
| ParamListInfo savedBoundParams = executorBoundParams; | |||
| executorBoundParams = queryDesc->params; | |||
There was a problem hiding this comment.
Could use a comment on why we do this.
marcocitus
reviewed
Jul 31, 2020
pykello
force-pushed
the
explain_analyze_execute
branch
from
6cc581d
to
84a8e92
Compare
marcocitus
reviewed
Aug 3, 2020
pykello
force-pushed
the
explain_analyze_execute
branch
from
84a8e92
to
fa9ce10
Compare
marcocitus
approved these changes
Aug 7, 2020
pykello
force-pushed
the
explain_analyze_execute
branch
from
fa9ce10
to
0c2f4ef
Compare
pykello
force-pushed
the
explain_analyze_execute
branch
from
0c2f4ef
to
7b74eca
Compare
This was referenced Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Support EXPLAIN ANALYZE EXECUTE and EXPLAIN EXECUTE.
Fixes #4074, #2009, #982.
To support EXPLAIN ANALYZE EXECUTE:
pqSendQueryParams()doesn't accept multiple queries.worker_save_query_explain_analyze()to use the bound parameters when executing the task query.To support EXPLAIN EXECUTE: Fix
FetchRemoteExplainFromWorkersto send bound params along with the EXPLAIN query.