When replication factor > 1, all modifications are done via 2PC #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onderkalaci
force-pushed
the
drop_1pc_single_statement
branch
4 times, most recently
from
0bd8b34
to
611d7cb
Compare
onderkalaci
commented
Oct 15, 2021
| @@ -51,6 +64,13 @@ SELECT * FROM the_table; | |||
| 1 | 2 | 2 | |||
| (1 row) | |||
|
|
|||
| INSERT INTO the_replicated_table (a, b, z) VALUES (1, 2, 2); | |||
There was a problem hiding this comment.
This* is a side-effect that I didn't consider until I hit the error.
replication > 1ANDcitus.writable_standby_coordinator TO ONnow fails as we need to write 2PC record.
There was a problem hiding this comment.
I think that never really worked properly, since we also would not be able to write a shardstate record. A slightly better error message would be nice though.
onderkalaci
force-pushed
the
drop_1pc_single_statement
branch
from
611d7cb
to
4a72228
Compare
marcocitus
approved these changes
Oct 19, 2021
onderkalaci
force-pushed
the
drop_1pc_single_statement
branch
from
4a72228
to
39e0453
Compare
Codecov Report
@@ Coverage Diff @@
## master #5379 +/- ##
==========================================
- Coverage 94.21% 94.18% -0.03%
==========================================
Files 215 215
Lines 42818 42814 -4
==========================================
- Hits 40339 40324 -15
- Misses 2479 2490 +11 |
onderkalaci
force-pushed
the
drop_1pc_single_statement
branch
2 times, most recently
from
14e18af
to
fa48ada
Compare
With Citus 9.0, we introduced `citus.single_shard_commit_protocol` which defaults to 2PC. With this commit, we prevent any user to set it to 1PC and drop support for `citus.single_shard_commit_protocol`. Although this might add some overhead for users, it is already the default behaviour (so less likely) and marking placements as INVALID is much worse.
onderkalaci
force-pushed
the
drop_1pc_single_statement
branch
from
fa48ada
to
64980c1
Compare
This was referenced Nov 8, 2021
onderkalaci
added a commit
that referenced
this pull request
Jul 31, 2023
Prior to this commit, the code would skip processing the errors happened for local commands. Prior to #5379, it might make sense to allow the execution continue. But, as of today, if a modification fails on any placement, we can safely fail the execution.
onderkalaci
added a commit
that referenced
this pull request
Jul 31, 2023
Prior to this commit, the code would skip processing the errors happened for local commands. Prior to #5379, it might make sense to allow the execution continue. But, as of today, if a modification fails on any placement, we can safely fail the execution.
onderkalaci
added a commit
that referenced
this pull request
Aug 1, 2023
Prior to this commit, the code would skip processing the
errors happened for local commands.
Prior to #5379, it might
make sense to allow the execution continue. But, as of today,
if a modification fails on any placement, we can safely fail
the execution.
onderkalaci
added a commit
that referenced
this pull request
Aug 1, 2023
Prior to this commit, the code would skip processing the
errors happened for local commands.
Prior to #5379, it might
make sense to allow the execution continue. But, as of today,
if a modification fails on any placement, we can safely fail
the execution.
onderkalaci
added a commit
that referenced
this pull request
Aug 1, 2023
Prior to this commit, the code would skip processing the errors happened for local commands. Prior to #5379, it might make sense to allow the execution continue. But, as of today, if a modification fails on any placement, we can safely fail the execution. The first commit show the problem in action. The second commit includes the fix and the test fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Citus 9.0, we introduced
citus.single_shard_commit_protocolwhichdefaults to 2PC.
With this commit, we prevent any user to set it to 1PC and drop support
for
citus.single_shard_commit_protocol.Although this might add some overhead for users, it is already the default
behaviour (so less likely) and marking placements as INVALID is much
worse.
DESCRIPTION: Drops GUC citus.single_shard_commit_protocol, defaults to 2PC