Introduce alter view propagation #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velioglu
force-pushed
the
velioglu/alter_view_propagation
branch
9 times, most recently
from
abb431c
to
7be079e
Compare
velioglu
changed the title
onderkalaci
reviewed
Apr 28, 2022
onderkalaci
reviewed
Apr 28, 2022
There was a problem hiding this comment.
Looks good overall, I need to test this a bit more. For now, few comments:
- Can we avoid overriding the object types in the statements, but let the code handle both views and tables where necessary?
- Can we send the exact commands that are executed on the coordinator (e.g., do not change
ALTER TABLEtoALTER VIEWon the deparser - Lets add the comments that we discussed earlier where we do the process redirection
onderkalaci
reviewed
May 5, 2022
onderkalaci
reviewed
May 5, 2022
velioglu
force-pushed
the
velioglu/view_propagation
branch
14 times, most recently
from
8b95cfd
to
2413c09
Compare
velioglu
force-pushed
the
velioglu/alter_view_propagation
branch
21 times, most recently
from
9c4638f
to
eadf2a4
Compare
onderkalaci
reviewed
May 12, 2022
onderkalaci
approved these changes
May 12, 2022
velioglu
force-pushed
the
velioglu/alter_view_propagation
branch
from
eadf2a4
to
0c02a51
Compare
Adds support for propagation ALTER VIEW commands to - Change owner of view - SET/RESET option - Rename view and view's column name - Change schema of the view Since PG also supports targeting views with ALTER TABLE commands, related code also added to direct such ALTER TABLE commands to ALTER VIEW commands while sending them to workers.
velioglu
force-pushed
the
velioglu/alter_view_propagation
branch
from
0c02a51
to
1875516
Compare
Codecov Report
@@ Coverage Diff @@
## master #5914 +/- ##
==========================================
+ Coverage 92.67% 92.69% +0.01%
==========================================
Files 236 236
Lines 48203 48422 +219
==========================================
+ Hits 44672 44884 +212
- Misses 3531 3538 +7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: Adds support for propagating ALTER VIEW commands
Introduce alter view propagation
Adds support for propagating alter view commands (except setting/resetting default values as Citus doesn't support update/delete on views). Note that both ALTER VIEW and ALTER TABLE supports have been added, since PG supports both of those syntax to alter view.