Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Postgres 11 COPY #197

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Add support for Postgres 11 COPY #197

merged 1 commit into from
Dec 5, 2018

Conversation

marcocitus
Copy link
Member

@marcocitus marcocitus commented Dec 3, 2018 •
edited
Loading

Fixes #196

Implement the BeginForeignInsert and EndForeignInsert to properly support COPY and insert in Postgres 11.

@mtuncer
Copy link
Member

mtuncer commented Dec 4, 2018

we are using branch develop_v1x. develop branch is for 2.0 development which is on hold for quite some time.

Could you rebase this PR to develop_v1x ?

@marcocitus
Copy link
Member Author

Sure, rebased.

@marcocitus marcocitus changed the base branch from master to develop_v1x December 4, 2018 10:17
mtuncer
mtuncer approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@mtuncer mtuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add a regression test too

@mtuncer mtuncer merged commit 8141c79 into develop_v1x Dec 5, 2018
@mtuncer mtuncer deleted the pg11_copy branch December 5, 2018 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtuncer mtuncer mtuncer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcocitus @mtuncer @marcoslot