pg12 compatibility related changes #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mtuncer
commented
Feb 17, 2020
mtuncer
commented
- fix the build
- revisit data file naming method. (use the old logic in pre-pg12)
PG12 does not maintain relfilenode for foreign tables. It broke cstore's default file name creation logic. New code is simpler.
mtuncer
changed the title
serprex
reviewed
Feb 17, 2020
| Oid databaseOid = relationFileNode.dbNode; | ||
| Oid relationFileOid = relationFileNode.relNode; | ||
|
|
||
| Oid databaseOid = MyDatabaseId; | ||
| StringInfo cstoreFilePath = makeStringInfo(); | ||
| appendStringInfo(cstoreFilePath, "%s/%s/%u/%u", DataDir, CSTORE_FDW_NAME, |
There was a problem hiding this comment.
Will there need to be upgrade instructions for this?
There was a problem hiding this comment.
behavior is the same as long as you stay in the same PG version. We never officially supported upgrading PG. So we should be fine there
serprex
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.