Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to signed integers for all identifiers #114

Merged
merged 1 commit into from
Jun 22, 2015

Conversation

jasonmp85
Copy link
Collaborator

PostgreSQL doesn't have unsigned types, so using them when storing a value in a table doesn't make sense.

PostgreSQL doesn't have unsigned types, so using them when storing a
value in a table doesn't make sense.
@jasonmp85
Copy link
Collaborator Author

Assigning to @sumedhpathak, since we discussed this a bit in #110

@jasonmp85
Copy link
Collaborator Author

Reassigning to @onderkalaci because @sumedhpathak oversubscription, etc.

@onderkalaci can you look at this? It's pretty simple.

@onderkalaci
Copy link
Member

@jasonmp85
I looked at the changes. All look fine.

  • I ran regression tests
  • Checked if this changes could lead to any problems (ie: signed-unsigned comparison problems). But, all changes look safe.
  • I searched for other uint* usage. I see no other PostgreSQL related variable.

We can :shipit: . I let you merge whenever you want to merge.

jasonmp85 added a commit that referenced this pull request Jun 22, 2015
Switch to signed integers for all identifiers

cr: @onderkalaci
@jasonmp85 jasonmp85 merged commit ba601b3 into develop Jun 22, 2015
@jasonmp85 jasonmp85 deleted the feature-remove_unsigned branch June 22, 2015 16:01
@jasonmp85 jasonmp85 modified the milestone: v1.2 Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants