Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved checking of vertex duplicates #15

Merged
merged 5 commits into from
May 19, 2021
Merged

Conversation

LaurensJN
Copy link

See #14
Improved export computing time by a lot

@LaurensJN
Copy link
Author

Also fixed #13.

  • Each semantic surface is only added once
  • Decoupled the creation of semantic surfaces and the linking of individual faces to the semantic surface
  • Support for objects that partly have a semantic surface and partly do not

@liberostelios
Copy link
Collaborator

That's really awesome! Thanks a lot.

I haven't found time to review the code yet, but everything seems in place for a merge. @konmast3r should we proceed?

@konmast3r
Copy link
Collaborator

konmast3r commented May 19, 2021 via email

@liberostelios liberostelios merged commit 0c2ad2b into cityjson:main May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants