Add early fail for get_normal_newell when the provided polygon is too small (< 3)
#177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the build failed trying to install/build cjvalpy 0.3.2. Maybe using latest cjvalpy would already resolve this? |
|
Updating |
mdjong1
force-pushed
the
fix-normal-calculation-for-invalid-polys
branch
from
dee8daf
to
e17d88e
Compare
mdjong1
force-pushed
the
fix-normal-calculation-for-invalid-polys
branch
from
e17d88e
to
234a7ad
Compare
mdjong1
commented
Nov 21, 2023
| @@ -39,6 +39,8 @@ def get_normal_newell(poly): | |||
| ne = i + 1 | |||
| if (ne == len(poly)): | |||
| ne = 0 | |||
| if len(poly[i]) < 3 or len(poly[ne]) < 3: | |||
There was a problem hiding this comment.
Actually not 100% sure with it being here and checking for poly elements. I had it outside before with if len(poly) < 3, but that also felt weird. lmk what would be best
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176