Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Service Page updates #49

Merged
merged 6 commits into from
Jan 3, 2018

Conversation

ifsimicoded
Copy link
Contributor

update 311 links with outbound urls
update contact section to handle multiple contacts (rely on stub data as Joplin model isn't updated)
update related service links based on Celine's mocks closes #41

Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks 🎉 to me, just a note on the API response structure

"zip": "78744",
"country": "United States"
},
"hours": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a slightly different structure for contacts & locations currently cityofaustin/joplin#39 (comment). Some goofiness is there because of the default Django rest framework structure, but I separated contact & location. Not sure if that's the right way to model it or not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some comments here -- cityofaustin/joplin#39
but basically, since there will be multiple locations and points of contact, I think there will be cases where these two should be associated when shown to residents. For ex, contact info for Austin Resource Recovery main drop off location vs Treehouse where classes are hosted.

@mateoclarke mateoclarke changed the base branch from sd-cssbreakdown to master December 27, 2017 19:28
Copy link
Contributor

@mateoclarke mateoclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice_key_peele

text={service.title}
/>
</div>
)
}
</div>
<a className="coa-section__link" href="#">See a Full List of 311 Services</a>
<a className="coa-section__link" href="http://311.austintexas.gov/reports/list_services">See a Full List of 311 Services</a>
Copy link
Contributor

@mateoclarke mateoclarke Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do target="_blank" on these since we link them to a separate site? Or since it is the same domain, maybe not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure, I can ask Celine what her thoughts are

@@ -22,7 +23,7 @@ class Hours extends Component {
hours.map((hour, index) =>
<tr key={index}>
<th scope="row">{hour.day_of_week}</th>
<td>{hour.start_time} - {hour.end_time}</td>
<td>{moment(hour.start_time, "HH:mm:ss").format('h:mm A')} - {moment(hour.end_time, "HH:mm:ss").format('h:mm A')}</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ifsimicoded ifsimicoded merged commit 0ac782d into master Jan 3, 2018
@ifsimicoded ifsimicoded deleted the sd-updates-311linkRelatedLinksContantInfo branch March 13, 2018 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 'related services' section
3 participants