Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account creation using NEP-2 #60

Closed
lock9 opened this issue Mar 12, 2021 · 2 comments
Closed

Account creation using NEP-2 #60

lock9 opened this issue Mar 12, 2021 · 2 comments
Assignees
@luc10921

Comments

@lock9
Copy link

lock9 commented Mar 12, 2021 •
edited by meevee98
Loading

Create a single account using NEP-2 (password is needed)

NewAccount()
NewAccountFromEncryptedKey(nep2: string, password: string)
NewAccountFromPrivateKey()
@meevee98 meevee98 self-assigned this Mar 26, 2021
@meevee98 meevee98 added this to the Belerofonte milestone Mar 26, 2021
@meevee98
Copy link
Contributor

Summary or problem description
Account creation is not using the method proposed on NEP-2.

Do you have any solution you want to propose?
Account creation should follow the standardized passphrase-protected private key format. This requirement should cover the private key generation and encryption steps detailed here.

Additional contextual information

This was referenced Mar 26, 2021
Closed
Closed
@meevee98 meevee98 assigned lock9 and unassigned meevee98 Apr 7, 2021
lock9 added a commit to simplitech/neo-mamba that referenced this issue Apr 8, 2021
@lock9
Merge remote-tracking branch 'origin/CityOfZion#60' into neo-mamba#59
0f014df 
# Conflicts:
#	neo3/wallet/__init__.py
#	neo3/wallet/account.py
#	requirements.txt
#	tests/wallet/test_account.py
@meevee98 meevee98 removed this from the Belerofonte milestone Apr 9, 2021
@meevee98 meevee98 assigned luc10921 and unassigned lock9 Apr 23, 2021
luc10921 pushed a commit to simplitech/neo-mamba that referenced this issue Apr 28, 2021
@ixje
Account creation using NEP-2 CityOfZion#60
6a9b8aa
luc10921 pushed a commit to simplitech/neo-mamba that referenced this issue Apr 29, 2021
@ixje
Account creation using NEP-2 CityOfZion#60
3c9d481
@meevee98 meevee98 mentioned this issue May 3, 2021
Closed
luc10921 pushed a commit to simplitech/neo-mamba that referenced this issue May 4, 2021
@ixje
Account creation using NEP-2 CityOfZion#60
3d56a3b
ixje added a commit that referenced this issue May 7, 2021
@luc10921 @ixje
Account creation using NEP-2 #60 (#81)
aad6dfe 
* Account creation using NEP-2 #60

* Finished testing.

* Changed the constructor and moved all local imports to the top of the file

* added some descriptions to methods

* generated new accounts using rc1 instead of preview3

* updated code according to feedback

* added a test trying to create an account with an encrypted key and the wrong password

* added validade_address() and removed the underscore after `data`.

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
Co-authored-by: luc10921 <lucas.uezu@simpli.com.br>
@meevee98 meevee98 closed this as completed May 7, 2021
@meevee98
Copy link
Contributor

meevee98 commented May 7, 2021

Closed with #81

ixje added a commit that referenced this issue Jun 14, 2021
@ixje @luc10921 @meevee98
Feature wallet (#111)
469dde8 
* Account creation using NEP-2 #60 (#81)

* Account creation using NEP-2 #60

* Finished testing.

* Changed the constructor and moved all local imports to the top of the file

* added some descriptions to methods

* generated new accounts using rc1 instead of preview3

* updated code according to feedback

* added a test trying to create an account with an encrypted key and the wrong password

* added validade_address() and removed the underscore after `data`.

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>
Co-authored-by: luc10921 <lucas.uezu@simpli.com.br>

* Wallet creation using NEP-6 (#80)

* Wallet creation using NEP-6

* moved ScryptParameter default to constructor

* changed None returns to raising exceptions and removed unnecessary method

* change default values

* import wallet package in the unit test

* don't persist as default

* code review

* move new_wallet logic to constructor

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>

* clean up imports, typing, docs

* Update accounts to RC2

* Import private key (#87)

* Decrypting NEP-2 account (#92)

Co-authored-by: luc10921 <lucas.uezu@simpli.com.br>

* Remove mutable object from default arguments

* Add and remove accounts in the wallet (#89)

* Add support to multiple accounts in the same wallet

* doc strings and rename method

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>

* Add extra keys (#94)

* Add extra keys

* change extra typing and to_json conversion + rebase

* fix unit tests

* Exporting wallet using NEP-6 format (#83)

* Export wallet using NEP-6 format

* fix lint e type-check

Co-authored-by: Erik van den Brink <git@erikvandenbrink.com>

* - fix isdefault -> isDefault
- fix version 3.0 -> 1.0
- use f-strings
- some docs strings and other cleanup

* - remove tests that could throw away user wallets
- cleanup test wallet

* fix account from json overriding address for multisig account

* merge account and accountcontract into one module

* Add single account signing

* fix circle-ci

* Add multisig signing support

* Add fee calculation helpers

* bump requirements

* Add signing example (#109)

* silence circleci

Co-authored-by: Lucas Kenji Uezu <49196318+luc10921@users.noreply.github.com>
Co-authored-by: luc10921 <lucas.uezu@simpli.com.br>
Co-authored-by: Mirella de Medeiros <mirellamedeiros.09@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luc10921 luc10921

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@meevee98 @lock9 @luc10921