Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Proper container/component architecture. #81

Closed
Alexintosh opened this issue Aug 11, 2017 · 2 comments
Closed

Enhancement: Proper container/component architecture. #81

Alexintosh opened this issue Aug 11, 2017 · 2 comments

Comments

@Alexintosh
Copy link
Contributor

I'm submitting a ... (check one with "x")
[ ] bug report
[ ] feature request
[X] proposal

Current behavior:
At the moment many components are using the connect function from redux which makes them containers.

Expected behavior:
Proper separation of pure presentational components from stateful components as explained in the container/component architecture.
It's a good idea to use styled-components for pure presentational components.

@Alexintosh
Copy link
Contributor Author

I'll be glad to work on this.
It's not completely clear how the process works to get PRs reviewed, I made a couple based on github issues last week. I'd appreciate if someone cold add me on Trello.

@shawnmclean
Copy link
Contributor

This falls under #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants