--added webtest for CRM-11986 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should use $this->openCiviPage() instead of just $this->open(). Can you update your test for the same. |
eileenmcnaughton
referenced
this pull request
in eileenmcnaughton/civicrm-core
Jan 6, 2015
Edzelopez
added a commit
to Edzelopez/civicrm-core
that referenced
this pull request
Mar 20, 2015
CIVI-28 Added check for viewable lineitems in contribution search result...
f2boot
pushed a commit
to f2boot/civicrm-core
that referenced
this pull request
Sep 25, 2016
ErichBSchulz
pushed a commit
to ErichBSchulz/civicrm-core
that referenced
this pull request
Jan 3, 2017
Security Update 4.6.12
eileenmcnaughton
referenced
this pull request
in eileenmcnaughton/civicrm-core
May 20, 2018
… type This is a partial reviewer's commit on the work Matt did in civicrm#12007 (comment) It adds the new function & new construct but I spotted an error in the usage of the function & so want to add the usage changes more slowly & carefully
eileenmcnaughton
added a commit
that referenced
this pull request
May 21, 2018
Towards dev/financial/#16 Paypal unreliable getting payment processor type
eileenmcnaughton
added a commit
that referenced
this pull request
May 27, 2018
Towards dev/financial/#16 Paypal unreliable getting payment processor type
mfb
pushed a commit
to mfb/civicrm-core
that referenced
this pull request
Dec 15, 2018
CRM-12751 - upgraded tcpdf to 6.x
eileenmcnaughton
referenced
this pull request
in eileenmcnaughton/civicrm-core
Jan 16, 2019
security/core#16 - Smarty - Fix XSS in crmMoney plugin Closes #16 See merge request security/core!34
seamuslee001
added a commit
that referenced
this pull request
Sep 23, 2019
dev/membership/#16 Fix duplicate lineitems when creating a recurring membership via backend
totten
added a commit
to totten/civicrm-core
that referenced
this pull request
Nov 30, 2021
…ion-fix)
Overview
--------
Fixes a recent regression that prevents you from uninstalling extensions via
CLI. This specifically affects extensions which use managed entities.
Steps to reproduce
------------------
```
cv en afform
cv dis afform
cv ext:uninstall afform
```
Before
-------
```
[bknix-max:~/bknix/build/dmaster/web/sites/all/modules/civicrm] cv en afform && cv dis afform && cv ext:uninstall afform
Enabling extension "org.civicrm.afform"
Disabling extension "org.civicrm.afform"
Uninstalling extension "org.civicrm.afform"
Error: API Call Failed: Array
(
[entity] => Extension
[action] => uninstall
[params] => Array
(
[keys] => Array
(
[0] => org.civicrm.afform
)
[debug] => 1
[version] => 3
)
[result] => Array
(
[error_code] => unauthorized
[entity] => Extension
[action] => uninstall
[trace] => #0 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(147): Civi\API\Kernel->authorize(Object(Civi\Api4\Provider\ActionObjectProvider), Object(Civi\Api4\Generic\DAODeleteAction))
#1 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAODeleteAction))
#2 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute()
civicrm#3 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(467): civicrm_api4('OptionValue', 'delete', Array)
civicrm#4 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(303): CRM_Core_ManagedEntities->removeStaleEntity(Object(CRM_Core_DAO_Managed))
civicrm#5 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(134): CRM_Core_ManagedEntities->reconcileUnknownModules()
civicrm#6 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(409): CRM_Core_ManagedEntities->reconcile()
civicrm#7 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Extension/Manager.php(483): CRM_Core_Invoke::rebuildMenuAndCaches(true)
civicrm#8 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/Extension.php(183): CRM_Extension_Manager->uninstall(Array)
civicrm#9 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_uninstall(Array)
civicrm#10 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Provider\MagicFunctionProvider->invoke(Array)
civicrm#11 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array)
civicrm#12 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Extension', 'uninstall', Array)
civicrm#13 phar:///home/me/bknix/bin/cv/src/Command/BaseCommand.php(49): civicrm_api('Extension', 'uninstall', Array)
civicrm#14 phar:///home/me/bknix/bin/cv/src/Command/ExtensionUninstallCommand.php(63): Civi\Cv\Command\BaseCommand->callApiSuccess(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput), 'Extension', 'uninstall', Array)
civicrm#15 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Command/Command.php(257): Civi\Cv\Command\ExtensionUninstallCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
civicrm#16 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(850): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
civicrm#17 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRunCommand(Object(Civi\Cv\Command\ExtensionUninstallCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
civicrm#18 phar:///home/me/bknix/bin/cv/src/Application.php(46): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
civicrm#19 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(124): Civi\Cv\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
civicrm#20 phar:///home/me/bknix/bin/cv/src/Application.php(15): Symfony\Component\Console\Application->run()
civicrm#21 phar:///home/me/bknix/bin/cv/bin/cv(27): Civi\Cv\Application::main('phar:///Users/t...')
civicrm#22 /home/me/bknix/bin/cv(14): require('phar:///Users/t...')
civicrm#23 {main}
[is_error] => 1
[error_message] => Authorization failed
)
)
```
After
-----
Works
Comment
-------
I encountered this while working on E2E test-coverage for other changes.
The E2E test coverage had worked on a previous iteration of 5.45.alpha1 but
failed when I rebased. Consequently, this means
You can see a prior draft of the E2E test [here](https://github.com/totten/shimmy/blob/master-reorg/shimmy/tests/phpunit/E2E/Shimmy/LifecycleTest.php#L56-L77).
However, it's being reworked as a core patch.
I'd suggest accepting this without a test - because (a) it's a regression and (b) there will be coverage from the pending change.
eileenmcnaughton
added a commit
that referenced
this pull request
Mar 11, 2023
fix notice in non-dialog mode too, make var name clearer, fix another notice
This was referenced Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webtest for CRM-11986. Added function in ests/phpunit/WebTest/Event/AddPricesetTest.php to check line items are created when price set has more then 1 field for event participant.