CRM-11926 add a better error handling for db errors in the api #5

tttp · 2013-03-01T13:17:21Z

YEAP! only this single commit this time.

So to get it clean:
git fetch civicrm master:name_of_your_feature (CRM-11926_upstream in this case)
git checkout name_of_your_feature
do the modifications, git cherry-pick sha of the commit you want from your other branches

!!! git status says you are ok (because it commits automatically)
git push name_of_your_feature

and pull request

Trivial, isn't it? ;)

CRM-11926 add a better error handling for db errors in the api

CRM-12389

Bug-fix: removed duplicate class variable declaration. CRM-12464

…mentioned in comment by dgg after the initial QA round

VAT-389 Added form for CiviContribute Component Settings

CIVI-28 Multiple commits

dedupe datatable checkbox fixes

Provide appropriate notification type, map severity to integers

CRM-12163

Atrium 3767 fix searching on memebrship type in advanced search

The recent revision #9595 updated `ExternalBatch` to produce a more informative error message. However, in the test environment used by `flexmailer`, there was exactly 1 value in `$_ENV` (even if `variables_order` was misconfigured). This should make the test a bit harder to trip-up by affirmatively checking for the most common environment variable. Review note: In the known universe, the only direct references to `ExternalBatch` are in `CiviUnitTestCase`, so this shouldn't impact any runtime logic.

@jitendrapurohit

…tus-of-linked-cases CRM-21498: Implement Option to Change Status of Linked Cases CRM-21609 - Correctly handle PayPalPro recurring payments whose amount doesn't match the initial contribution CRM-21627: makeMultilingual: update dbLocale to avoid fatal if lcMessages was not set. CRM-21627: makeMultilingual: update dbLocale to avoid fatal if lcMessages was not set (adds unit-test fix by Monish Deb) CRM-21644, Fixed set default for Preferred Communication Method ---------------------------------------- * CRM-21644: Preferred Communication Method is not set to default for contact https://issues.civicrm.org/jira/browse/CRM-21644 CRM-21591 Add Test of formatUnitSize Function CRM-21591 Fix PHP Notice A non well formed numeric value encountered on Misc settings page PHP Notice: A non well formed numeric value encountered CRM-21647 - Fatal error on deleting any contribution record CRM-21635 - Expose contact custom data on contribution summary report CRM-21629 System Check: Set User Agent to security filters accept check CRM-21621 - Provide ability to delete first website field CRM-21652: Fix numerous problems with anonymous users registering themselves CRM-21528 fix add2Group CRM-21225 Allow for display profile alternate - schema changes only Rename column to be frontend_title Deduplicate from email address code and add a setting to disable sending from contact email addresses Fix for 'from email' showing twice on Thankyou-receipts form Update help paths Only include email address on contribution pdf task. Make sure we pass through from_email_address when non-default selected Further fix for email address missing on contribution thank-you letters CRM-19107 Fixed PayPal Express redirection issue. corrected syntax Standalone code contributor from now. CRM-17352 - Use Backbone.noConflict CRM-17352 - Use CiviCRM to load scripts for consistency CRM-17352 fix display of modal on drupal8 (civicrm#5) Remove restriction on 'Update Subscription' when a recurring contribution has a linked membership CRM-21533 : Outbound setting reverts in non-production sites on executing sched job Fix for CRM-21485 - Tax not added when renewing membership in backend Added code as suggested by @jitendrapurohit Removed changes of First commit Blank line removed CRM-18048 - long custom group names cause report failure Ensure custom group names are never a length that can cause this problem. Also, update test infrastructure to prevent this problem from being masked. CRM-21521: fix nested multipart handling When for example a multipart-report email body's first part is multipart-related, extract the text correctly instead of crashing. This logic should handle all kinds of weird multipart nesting, up to MIME_MAX_RECURSION levels deep. CRM-21159 Address fields cause DB errors when adding contacts to group from Search Builder Code refactor CRM-21652: Without using 'finally' clause CRM-15049: Fixed include/exclude search for parent groups (civicrm#10546) * CRM-15049: Fixed include/exclude search for parent groups * Fixed the style errors * CRM-15049: update comment CRM-21587, Notice error for Grant date fields (civicrm#11497) * CRM-21587, fixed code to add formattype for date field ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * CRM-21587, removed cruft code ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * CRM-21587, generated DAO file ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * CRM-21587, removed cruft code ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * Standalone code contributor from now. call hooks even if joomla isn't bootstraped CRM-21225 Changes to UI to implement the frontend_title field to allow for overriding of the Profile title fix CRM-21444: use contact_type name instead of label CRM-21663: Fix Campaign Search and result structure CRM-21613: Search issues on 'Manage Tag' page additional fixes Modified--getting currencies from civicrm_currency table instead being hard-coded. CRM-21664 CRM-21634 Stdise search fields as they relate to contacts CRM-21323 : Fix backend credit card payment processor selection CRM-21155 - Hook batchItems does not change the csv export Change to use results of hook when exporting. Fix CRM-21155 by removing batchItems entirely Consistent wording of Email - Send Now task CRM-21670 - Search of active relationships does not appear on Relationship Report https://issues.civicrm.org/jira/browse/CRM-21670 CRM-21651 - Activity_Email/SMS_Add - Fix loading failed when no contact is found Add test for DB error on search add to group CRM-21159 I've also removed an unused parameter & a couple of require_once calls CRM-21667: Fixed timezone handoff from Drupal6. CRM-21672 fix intra-rc regression, fatal when deleting participants Change-Id: Iccbd17d53f07a93c74ce46e9539d1768019a2532 CRM-21656: Backend Membership with Priceset applies taxes twice to line_item CRM-17647 improve testing on the thousand separator. As part of fixing thousand separator issues we can use the deprecated flag to identify when the BAO_Contribution::create is called without skip_clean_money as we want to move all cleaning to close to submit. First, however, we need to stop calling that function directly in the test suite (or only call with skip_clean_money if we are specifically testing it). Am checking how jenkins likes this format (which was no good on 5.3) & will change others if cheerful Fix mock test data for PaymentProcessor object. This only affects unit tests. When dummy data is generated for a PaymentProcessor it will be more usable CRM-17647 test fixes towards ensuring we never rely on the BAO to clean money. We need to deprecate out BAO cleaning of money. Test fixes ensure we use the (safe) api rather than BAO::create - no functional change Minor api tidy up. It is recommended practice to pass the entity to the api. This minor fix up supports that CRM-21260: CiviMail compose UI very slow to initialize, CRM-21316: Simplify getRecipients fn test failure fix avoid recipient rebuild on preview,sendTest and simple save CRM-14834 - fix activity export when relationship in export fields CRM-21423 test that emails are exported for multiple types I was thinking this might fail but it is passing so let's lock it in caller Add recurring contribution link to membership and contribution detail CRM-17647 fix for currency on batch entry CRM-17647 test fixes to avoid calling Contribution::create without skipCleanMoney Fix template variable for contribution_recur_id CRM-20707 include start/end dates when updating membership CRM-21684 contact subtype fields prevent inclusion in profile/receipt email Add API parameter for fix_address Defaults to true, but lets you skip address fixes if desired. EXT-56 - dm_install_cvext - Add helper for including extensions EXT-56 - Add com.iatspayments.civicrm to tarballs Add abstract core Task class Convert Event to use core Task class Fix docblock type definitions CRM-21683 Standardise filter in mailing summary report CRM-21623 - Smart Group Relative Date not saving for some fields in Advance Search CRM-21540 - Add support for auto-complete fields in the batch entry forms Disable sending email receipt from logged in contact ID / activity source contact Use fontawesome check for membership auto-renew status and add exclamation for auto-renew but error (eg. subscription cancelled). Fix typo (very recent) CRM-21660 Remove use of deprecated function on mapping_type CRM-21071 - Simplify event location form to not use ajax This form does not do anything dynamic so ajax was unnecessarily complex. CRM-21071 fix form to hold id before callling (nasty) block:create CRM-17647 fix for submitting payment with thousand separator CRM-17647 membership form fix for thousand processing error. CRM-21698 move formatting to processor class. This moves the fix for CRM-16460 to the processor class, providing a helper function. The fix put number formatting deep into the BAO - when they don't work right (depending on presence of money_format function I think) negative amounts become 0 Test fixes, towards CRM-17647 Test fixes towards never calling Contribution::Create without skipCleanMoney CRM-21701 - ensure street addresses are parsed Even if USPS street parsing is disabled. CRM-21334: Replace direct SQL query with BAO save call (to trigger hooks) Api4 - Update entity directory CRM-21687 fix issue with MariaDB 10.2 logging query writing due to current_timestamp and timestamp getting () added on the end in Maria10.2 CRM-16421 - composer.json - Include civicrm-setup library ---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421 CRM-16421 - gitignore - Ignore the flag-file for civicrm-setup ---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421 CRM-16421 - distmaker - Generate civicrm-*-wporg.zip Minor api clean up. Increase places where entity passed to 'basic_create' CRM-21256 Improve performance of payment processor load CRM-21524 - CRM\Export - Fix merge contacts when deceased

@jitendrapurohit

…t doesn't match the initial contribution CRM-21627: makeMultilingual: update dbLocale to avoid fatal if lcMessages was not set. CRM-21627: makeMultilingual: update dbLocale to avoid fatal if lcMessages was not set (adds unit-test fix by Monish Deb) CRM-21644, Fixed set default for Preferred Communication Method ---------------------------------------- * CRM-21644: Preferred Communication Method is not set to default for contact https://issues.civicrm.org/jira/browse/CRM-21644 CRM-21591 Add Test of formatUnitSize Function CRM-21591 Fix PHP Notice A non well formed numeric value encountered on Misc settings page PHP Notice: A non well formed numeric value encountered CRM-21647 - Fatal error on deleting any contribution record CRM-21635 - Expose contact custom data on contribution summary report CRM-21629 System Check: Set User Agent to security filters accept check CRM-21621 - Provide ability to delete first website field CRM-21652: Fix numerous problems with anonymous users registering themselves CRM-21528 fix add2Group CRM-21225 Allow for display profile alternate - schema changes only Rename column to be frontend_title Deduplicate from email address code and add a setting to disable sending from contact email addresses Fix for 'from email' showing twice on Thankyou-receipts form Update help paths Only include email address on contribution pdf task. Make sure we pass through from_email_address when non-default selected Further fix for email address missing on contribution thank-you letters CRM-19107 Fixed PayPal Express redirection issue. corrected syntax Standalone code contributor from now. CRM-17352 - Use Backbone.noConflict CRM-17352 - Use CiviCRM to load scripts for consistency CRM-17352 fix display of modal on drupal8 (civicrm#5) Remove restriction on 'Update Subscription' when a recurring contribution has a linked membership CRM-21533 : Outbound setting reverts in non-production sites on executing sched job Fix for CRM-21485 - Tax not added when renewing membership in backend Added code as suggested by @jitendrapurohit Removed changes of First commit Blank line removed CRM-18048 - long custom group names cause report failure Ensure custom group names are never a length that can cause this problem. Also, update test infrastructure to prevent this problem from being masked. CRM-21521: fix nested multipart handling When for example a multipart-report email body's first part is multipart-related, extract the text correctly instead of crashing. This logic should handle all kinds of weird multipart nesting, up to MIME_MAX_RECURSION levels deep. CRM-21159 Address fields cause DB errors when adding contacts to group from Search Builder Code refactor CRM-21652: Without using 'finally' clause CRM-15049: Fixed include/exclude search for parent groups (civicrm#10546) * CRM-15049: Fixed include/exclude search for parent groups * Fixed the style errors * CRM-15049: update comment CRM-21587, Notice error for Grant date fields (civicrm#11497) * CRM-21587, fixed code to add formattype for date field ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * CRM-21587, removed cruft code ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * CRM-21587, generated DAO file ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * CRM-21587, removed cruft code ---------------------------------------- * CRM-21587: Notice error for grant date fields https://issues.civicrm.org/jira/browse/CRM-21587 * Standalone code contributor from now. call hooks even if joomla isn't bootstraped CRM-21225 Changes to UI to implement the frontend_title field to allow for overriding of the Profile title fix CRM-21444: use contact_type name instead of label CRM-21663: Fix Campaign Search and result structure CRM-21613: Search issues on 'Manage Tag' page additional fixes Modified--getting currencies from civicrm_currency table instead being hard-coded. CRM-21664 CRM-21634 Stdise search fields as they relate to contacts CRM-21323 : Fix backend credit card payment processor selection CRM-21155 - Hook batchItems does not change the csv export Change to use results of hook when exporting. Fix CRM-21155 by removing batchItems entirely Consistent wording of Email - Send Now task CRM-21670 - Search of active relationships does not appear on Relationship Report https://issues.civicrm.org/jira/browse/CRM-21670 CRM-21651 - Activity_Email/SMS_Add - Fix loading failed when no contact is found Add test for DB error on search add to group CRM-21159 I've also removed an unused parameter & a couple of require_once calls CRM-21667: Fixed timezone handoff from Drupal6. CRM-21672 fix intra-rc regression, fatal when deleting participants Change-Id: Iccbd17d53f07a93c74ce46e9539d1768019a2532 CRM-21656: Backend Membership with Priceset applies taxes twice to line_item CRM-17647 improve testing on the thousand separator. As part of fixing thousand separator issues we can use the deprecated flag to identify when the BAO_Contribution::create is called without skip_clean_money as we want to move all cleaning to close to submit. First, however, we need to stop calling that function directly in the test suite (or only call with skip_clean_money if we are specifically testing it). Am checking how jenkins likes this format (which was no good on 5.3) & will change others if cheerful Fix mock test data for PaymentProcessor object. This only affects unit tests. When dummy data is generated for a PaymentProcessor it will be more usable CRM-17647 test fixes towards ensuring we never rely on the BAO to clean money. We need to deprecate out BAO cleaning of money. Test fixes ensure we use the (safe) api rather than BAO::create - no functional change Minor api tidy up. It is recommended practice to pass the entity to the api. This minor fix up supports that CRM-21260: CiviMail compose UI very slow to initialize, CRM-21316: Simplify getRecipients fn test failure fix avoid recipient rebuild on preview,sendTest and simple save CRM-14834 - fix activity export when relationship in export fields CRM-21423 test that emails are exported for multiple types I was thinking this might fail but it is passing so let's lock it in caller Add recurring contribution link to membership and contribution detail additional fixes CRM-17647 fix for currency on batch entry CRM-17647 test fixes to avoid calling Contribution::create without skipCleanMoney Fix template variable for contribution_recur_id CRM-20707 include start/end dates when updating membership CRM-21684 contact subtype fields prevent inclusion in profile/receipt email Add API parameter for fix_address Defaults to true, but lets you skip address fixes if desired. EXT-56 - dm_install_cvext - Add helper for including extensions EXT-56 - Add com.iatspayments.civicrm to tarballs Add abstract core Task class Convert Event to use core Task class Fix docblock type definitions CRM-21683 Standardise filter in mailing summary report CRM-21623 - Smart Group Relative Date not saving for some fields in Advance Search CRM-21540 - Add support for auto-complete fields in the batch entry forms Disable sending email receipt from logged in contact ID / activity source contact Use fontawesome check for membership auto-renew status and add exclamation for auto-renew but error (eg. subscription cancelled). Fix typo (very recent) CRM-21660 Remove use of deprecated function on mapping_type CRM-21071 - Simplify event location form to not use ajax This form does not do anything dynamic so ajax was unnecessarily complex. CRM-21071 fix form to hold id before callling (nasty) block:create CRM-17647 fix for submitting payment with thousand separator CRM-17647 membership form fix for thousand processing error. CRM-21698 move formatting to processor class. This moves the fix for CRM-16460 to the processor class, providing a helper function. The fix put number formatting deep into the BAO - when they don't work right (depending on presence of money_format function I think) negative amounts become 0 Test fixes, towards CRM-17647 Test fixes towards never calling Contribution::Create without skipCleanMoney CRM-21701 - ensure street addresses are parsed Even if USPS street parsing is disabled. CRM-21334: Replace direct SQL query with BAO save call (to trigger hooks) Api4 - Update entity directory CRM-21687 fix issue with MariaDB 10.2 logging query writing due to current_timestamp and timestamp getting () added on the end in Maria10.2 CRM-16421 - composer.json - Include civicrm-setup library ---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421 CRM-16421 - gitignore - Ignore the flag-file for civicrm-setup ---------------------------------------- * CRM-16421: Work to get CiviCRM for WordPress in WordPress' official Repository https://issues.civicrm.org/jira/browse/CRM-16421 CRM-16421 - distmaker - Generate civicrm-*-wporg.zip Minor api clean up. Increase places where entity passed to 'basic_create' CRM-21256 Improve performance of payment processor load CRM-21524 - CRM\Export - Fix merge contacts when deceased

Fix dashboard popups CRM-12239

Use-case: 1. Open the editor a message template (eg `#/edit?id=17&lang=fr_FR`). This renders the edit screen. 2. Click on the "Preview" icon. 3. Close the "Preview" dialog. 4. Change the URL to navigate internally to another template (eg `#/edit?id=17&lang=de_DE`). This renders the edit screen again. 5. Click on the "Preview" icon. Before: * It subsequently opens two copies of the "Preview" dialog (each with slightly different options). Initially, you see one dialog. When that close, you will see the other dialog. * As you proceed through closing the dialogs, you may get console warnings because the dialogs have the same name -- and they consequently trip-up each other. After: * It only opens one copy of the "Preview" dialog. Technical Details: * When rendering the setup screen (`#1`/`civicrm#4`), it registers a listener which will handle the "Preview" clicks. But the listener is not properly unregistered. Consequently, old listeners hang around. So the click at step `civicrm#5` calls both the old+new listeners, creating two dialogs.

…ion-fix) Overview -------- Fixes a recent regression that prevents you from uninstalling extensions via CLI. This specifically affects extensions which use managed entities. Steps to reproduce ------------------ ``` cv en afform cv dis afform cv ext:uninstall afform ``` Before ------- ``` [bknix-max:~/bknix/build/dmaster/web/sites/all/modules/civicrm] cv en afform && cv dis afform && cv ext:uninstall afform Enabling extension "org.civicrm.afform" Disabling extension "org.civicrm.afform" Uninstalling extension "org.civicrm.afform" Error: API Call Failed: Array ( [entity] => Extension [action] => uninstall [params] => Array ( [keys] => Array ( [0] => org.civicrm.afform ) [debug] => 1 [version] => 3 ) [result] => Array ( [error_code] => unauthorized [entity] => Extension [action] => uninstall [trace] => #0 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(147): Civi\API\Kernel->authorize(Object(Civi\Api4\Provider\ActionObjectProvider), Object(Civi\Api4\Generic\DAODeleteAction)) #1 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAODeleteAction)) #2 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute() civicrm#3 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(467): civicrm_api4('OptionValue', 'delete', Array) civicrm#4 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(303): CRM_Core_ManagedEntities->removeStaleEntity(Object(CRM_Core_DAO_Managed)) civicrm#5 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(134): CRM_Core_ManagedEntities->reconcileUnknownModules() civicrm#6 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(409): CRM_Core_ManagedEntities->reconcile() civicrm#7 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Extension/Manager.php(483): CRM_Core_Invoke::rebuildMenuAndCaches(true) civicrm#8 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/Extension.php(183): CRM_Extension_Manager->uninstall(Array) civicrm#9 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_uninstall(Array) civicrm#10 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Provider\MagicFunctionProvider->invoke(Array) civicrm#11 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array) civicrm#12 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Extension', 'uninstall', Array) civicrm#13 phar:///home/me/bknix/bin/cv/src/Command/BaseCommand.php(49): civicrm_api('Extension', 'uninstall', Array) civicrm#14 phar:///home/me/bknix/bin/cv/src/Command/ExtensionUninstallCommand.php(63): Civi\Cv\Command\BaseCommand->callApiSuccess(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput), 'Extension', 'uninstall', Array) civicrm#15 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Command/Command.php(257): Civi\Cv\Command\ExtensionUninstallCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#16 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(850): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#17 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRunCommand(Object(Civi\Cv\Command\ExtensionUninstallCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#18 phar:///home/me/bknix/bin/cv/src/Application.php(46): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#19 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(124): Civi\Cv\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#20 phar:///home/me/bknix/bin/cv/src/Application.php(15): Symfony\Component\Console\Application->run() civicrm#21 phar:///home/me/bknix/bin/cv/bin/cv(27): Civi\Cv\Application::main('phar:///Users/t...') civicrm#22 /home/me/bknix/bin/cv(14): require('phar:///Users/t...') civicrm#23 {main} [is_error] => 1 [error_message] => Authorization failed ) ) ``` After ----- Works Comment ------- I encountered this while working on E2E test-coverage for other changes. The E2E test coverage had worked on a previous iteration of 5.45.alpha1 but failed when I rebased. Consequently, this means You can see a prior draft of the E2E test [here](https://github.com/totten/shimmy/blob/master-reorg/shimmy/tests/phpunit/E2E/Shimmy/LifecycleTest.php#L56-L77). However, it's being reworked as a core patch. I'd suggest accepting this without a test - because (a) it's a regression and (b) there will be coverage from the pending change.

CRM-11926 add a better error handling for db errors in the api

c56bd79

kurund added a commit that referenced this pull request Mar 1, 2013

Merge pull request #5 from tttp/CRM-11926_upstream

a544cd3

CRM-11926 add a better error handling for db errors in the api

kurund merged commit a544cd3 into civicrm:master Mar 1, 2013

pratik-joshi mentioned this pull request Mar 14, 2013

CRM-12062 : minor bug found by failing test case WebTest_Event_AddEventTest::testAddPaidEventNoTemplate #145

Merged

MegaphoneJon pushed a commit to MegaphoneJon/civicrm-core that referenced this pull request Apr 30, 2013

Merge pull request civicrm#5 from dlobo/CRM-12389

962cd43

CRM-12389

twomice pushed a commit to twomice/civicrm-core that referenced this pull request Apr 30, 2013

Merge pull request civicrm#5 from twomice/search

5c85601

Bug-fix: removed duplicate class variable declaration. CRM-12464

pratik-joshi pushed a commit to pratik-joshi/civicrm-core that referenced this pull request Mar 6, 2014

CRM-13965-qa-fixes : some major improvements and civicrm#5 issue fix …

f6bae84

…mentioned in comment by dgg after the initial QA round

pratik-joshi mentioned this pull request Mar 11, 2014

CRM-13965-qa-fixes #2642

Merged

rohankatkar pushed a commit to rohankatkar/civicrm-core-master that referenced this pull request May 22, 2014

Merge pull request civicrm#5 from rohankatkar/VAT-389

dbe4bf6

VAT-389 Added form for CiviContribute Component Settings

eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Jan 6, 2015

CRM-15680 fix custom data on survey & campaign

bf38705

Edzelopez added a commit to Edzelopez/civicrm-core that referenced this pull request Mar 17, 2015

Merge pull request civicrm#5 from Edzelopez/CIVI-28

62a2d2a

CIVI-28 Multiple commits

Kajakaran pushed a commit to Kajakaran/civicrm-core that referenced this pull request Apr 17, 2015

Merge pull request civicrm#5 from Kajakaran/dedupe-fixes

ef07660

dedupe datatable checkbox fixes

MegaphoneJon pushed a commit to MegaphoneJon/civicrm-core that referenced this pull request Apr 26, 2015

Merge pull request civicrm#5 from ginkgostreet/status-page-1

400c1ae

Provide appropriate notification type, map severity to integers

KarinG mentioned this pull request Jul 15, 2016

CRM-19061 Updated Reports from sprint #8539

Closed

KarinG mentioned this pull request Aug 7, 2016

(WIP) Sybunt - Rob's work #8823

Closed

f2boot pushed a commit to f2boot/civicrm-core that referenced this pull request Sep 25, 2016

Merge pull request civicrm#5 from dlobo/CRM-12163

78db8bb

CRM-12163

ErichBSchulz pushed a commit to ErichBSchulz/civicrm-core that referenced this pull request Jan 3, 2017

Merged in atrium-3767 (pull request civicrm#5)

b1521a9

Atrium 3767 fix searching on memebrship type in advanced search

davejenx mentioned this pull request Apr 24, 2017

CRM-20441 Fix issue where multiple activity Ids were not supported wh… #10212

Merged

colemanw pushed a commit that referenced this pull request Jan 15, 2018

CRM-17352 fix display of modal on drupal8 (#5)

2d1111e

magnolia61 pushed a commit to magnolia61/civicrm-core that referenced this pull request Jan 22, 2018

CRM-17352 fix display of modal on drupal8 (civicrm#5)

7c7a2d3

magnolia61 pushed a commit to magnolia61/civicrm-core that referenced this pull request Jan 26, 2018

CRM-17352 fix display of modal on drupal8 (civicrm#5)

f905202

dsnopek mentioned this pull request Apr 18, 2018

Fix the contact merge form on Drupal 8 #11992

Merged

sandrajvillagenetwork mentioned this pull request Aug 20, 2018

CRM-21811: Optimize advanced search by relationship with target g… #11732

Merged

mfb pushed a commit to mfb/civicrm-core that referenced this pull request Dec 15, 2018

Merge pull request civicrm#5 from colemanw/dashboard

fd4eed6

Fix dashboard popups CRM-12239

jmcclelland mentioned this pull request Dec 18, 2018

PCP report - fix number of donors and total committed. #13252

Merged

eileenmcnaughton pushed a commit that referenced this pull request Dec 20, 2018

dev/report/#5 - Fix mailing report unique count issue

57623a4

eileenmcnaughton mentioned this pull request Mar 23, 2021

[REF] Fold getACLs back into the calling function #19872

Merged

eileenmcnaughton mentioned this pull request Mar 31, 2021

dev/core#2164 Exporting in localized civicrm crashes due to long translations in columns T_Boolean #19957

Closed

eileenmcnaughton mentioned this pull request May 26, 2021

See how many tests fail with this check #20420

Closed

eileenmcnaughton mentioned this pull request Jun 21, 2021

Deprecate guess work in processPriceSet #20678

Closed

eileenmcnaughton mentioned this pull request Aug 29, 2021

find tests - closable on results #21304

Closed

eileenmcnaughton mentioned this pull request Sep 19, 2021

find tests #21534

Closed

eileenmcnaughton mentioned this pull request Oct 4, 2021

flexmailer - Update [CiviMail Draft] prefix to match BAO behavior #21715

Merged

totten mentioned this pull request Oct 4, 2021

dev/core#2836 install flexmailer by default on new installs [token] #21522

Merged

eileenmcnaughton mentioned this pull request Jan 12, 2022

Fully deprecate getTokenDetails #22483

Merged

This was referenced Feb 24, 2022

get membership type ID and number of terms from price_x fields #22825

Merged

Add handling for civimember disabled #22864

Merged

rashedulislam mentioned this pull request Mar 2, 2022

Call to undefined function civicrm_api3_create_error() in civicrm/civ… #22872

Merged

ginkgomzd mentioned this pull request Apr 26, 2022

correct logic for handling empty-array values for checkboxes; #23305

Merged

eileenmcnaughton mentioned this pull request Sep 26, 2022

Fix import class loading issue in entityTypes hook #24621

Merged

eileenmcnaughton mentioned this pull request Feb 18, 2023

Fix test method eventCreatePaid for php 8.2 #25613

Closed

eileenmcnaughton mentioned this pull request Jun 2, 2023

Stop passing $ids to membership::create #26373

Merged

eileenmcnaughton mentioned this pull request Jul 27, 2023

[PHP8.2] Remove undeclared property #26947

Merged

eileenmcnaughton mentioned this pull request Aug 23, 2023

dev/core#2644 Add Scheduled Communications extension #27081

Merged

eileenmcnaughton mentioned this pull request Sep 4, 2023

Add simple smart group profiler #27232

Merged

eileenmcnaughton mentioned this pull request Sep 18, 2023

Use some code for offline as online participant for payment section #27486

Closed

eileenmcnaughton mentioned this pull request Oct 11, 2023

Update smarty localize for Smarty3 #27776

Merged

eileenmcnaughton mentioned this pull request Nov 8, 2023

Revisit the default Scheduled Jobs. Adjust the frequency… #28052

Merged

eileenmcnaughton mentioned this pull request Nov 26, 2023

Make financialacls require civi-contribute #28318

Merged

This was referenced Jan 4, 2024

Add system check to warn if CiviReport disabled & logging enabled #28863

Merged

Logging detail test #28869

Closed

This was referenced Jun 19, 2024

WIP: Fix for https://lab.civicrm.org/dev/core/-/issues/5095 #29736

Closed

Enable message admin by default on new installs #30503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CRM-11926 add a better error handling for db errors in the api #5

CRM-11926 add a better error handling for db errors in the api #5

tttp commented Mar 1, 2013

CRM-11926 add a better error handling for db errors in the api #5

CRM-11926 add a better error handling for db errors in the api #5

Conversation

tttp commented Mar 1, 2013