fix CRM-11995 #9

dlobo · 2013-03-01T19:03:25Z

No description provided.

fix CRM-11995

totten · 2013-03-01T20:04:58Z

Tip: When doing a code-reformat as well as code-change, I try to:

Do code reformat
Commit
Do code change
Commit
Push

There's no real drawback because git has local commits, and this makes it easier to read the changes.

dlobo · 2013-03-01T20:06:43Z

yes, will do in future. Many a time, u realize the code is not formatted nicely in the middle of the code change

CRM-12656

INFRA 32 - Batch #9

CIVI-28 Added check for permissions while search results are being displayed on contribution search, advanced search and contact summary page (Contributions tab)

select all option in toggleselect

CRM-13823 Sort status messages by severity, name - even in API

CRM-17402 Google Maps API sometimes tries to call initMap callback be…

remove obsolete README

CRM-17654 Allow for multiple relationship types to be used in the relationship report

The recent revision #9595 updated `ExternalBatch` to produce a more informative error message. However, in the test environment used by `flexmailer`, there was exactly 1 value in `$_ENV` (even if `variables_order` was misconfigured). This should make the test a bit harder to trip-up by affirmatively checking for the most common environment variable. Review note: In the known universe, the only direct references to `ExternalBatch` are in `CiviUnitTestCase`, so this shouldn't impact any runtime logic.

PG-344: CiviCRM-4.6.21 update

…setting fixed.

Accessibility #9: Regression - js error due to alertDismissal setting fixed.

) Co-authored-by: Tim Otten <totten@civicrm.org>

…ion-fix) Overview -------- Fixes a recent regression that prevents you from uninstalling extensions via CLI. This specifically affects extensions which use managed entities. Steps to reproduce ------------------ ``` cv en afform cv dis afform cv ext:uninstall afform ``` Before ------- ``` [bknix-max:~/bknix/build/dmaster/web/sites/all/modules/civicrm] cv en afform && cv dis afform && cv ext:uninstall afform Enabling extension "org.civicrm.afform" Disabling extension "org.civicrm.afform" Uninstalling extension "org.civicrm.afform" Error: API Call Failed: Array ( [entity] => Extension [action] => uninstall [params] => Array ( [keys] => Array ( [0] => org.civicrm.afform ) [debug] => 1 [version] => 3 ) [result] => Array ( [error_code] => unauthorized [entity] => Extension [action] => uninstall [trace] => #0 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(147): Civi\API\Kernel->authorize(Object(Civi\Api4\Provider\ActionObjectProvider), Object(Civi\Api4\Generic\DAODeleteAction)) #1 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/Api4/Generic/AbstractAction.php(234): Civi\API\Kernel->runRequest(Object(Civi\Api4\Generic\DAODeleteAction)) #2 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(85): Civi\Api4\Generic\AbstractAction->execute() civicrm#3 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(467): civicrm_api4('OptionValue', 'delete', Array) civicrm#4 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(303): CRM_Core_ManagedEntities->removeStaleEntity(Object(CRM_Core_DAO_Managed)) civicrm#5 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/ManagedEntities.php(134): CRM_Core_ManagedEntities->reconcileUnknownModules() civicrm#6 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Core/Invoke.php(409): CRM_Core_ManagedEntities->reconcile() civicrm#7 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/CRM/Extension/Manager.php(483): CRM_Core_Invoke::rebuildMenuAndCaches(true) civicrm#8 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/v3/Extension.php(183): CRM_Extension_Manager->uninstall(Array) civicrm#9 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Provider/MagicFunctionProvider.php(89): civicrm_api3_extension_uninstall(Array) civicrm#10 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(149): Civi\API\Provider\MagicFunctionProvider->invoke(Array) civicrm#11 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/Civi/API/Kernel.php(81): Civi\API\Kernel->runRequest(Array) civicrm#12 /home/me/bknix/build/dmaster/web/sites/all/modules/civicrm/api/api.php(22): Civi\API\Kernel->runSafe('Extension', 'uninstall', Array) civicrm#13 phar:///home/me/bknix/bin/cv/src/Command/BaseCommand.php(49): civicrm_api('Extension', 'uninstall', Array) civicrm#14 phar:///home/me/bknix/bin/cv/src/Command/ExtensionUninstallCommand.php(63): Civi\Cv\Command\BaseCommand->callApiSuccess(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput), 'Extension', 'uninstall', Array) civicrm#15 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Command/Command.php(257): Civi\Cv\Command\ExtensionUninstallCommand->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#16 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(850): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#17 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(193): Symfony\Component\Console\Application->doRunCommand(Object(Civi\Cv\Command\ExtensionUninstallCommand), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#18 phar:///home/me/bknix/bin/cv/src/Application.php(46): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#19 phar:///home/me/bknix/bin/cv/vendor/symfony/console/Application.php(124): Civi\Cv\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput)) civicrm#20 phar:///home/me/bknix/bin/cv/src/Application.php(15): Symfony\Component\Console\Application->run() civicrm#21 phar:///home/me/bknix/bin/cv/bin/cv(27): Civi\Cv\Application::main('phar:///Users/t...') civicrm#22 /home/me/bknix/bin/cv(14): require('phar:///Users/t...') civicrm#23 {main} [is_error] => 1 [error_message] => Authorization failed ) ) ``` After ----- Works Comment ------- I encountered this while working on E2E test-coverage for other changes. The E2E test coverage had worked on a previous iteration of 5.45.alpha1 but failed when I rebased. Consequently, this means You can see a prior draft of the E2E test [here](https://github.com/totten/shimmy/blob/master-reorg/shimmy/tests/phpunit/E2E/Shimmy/LifecycleTest.php#L56-L77). However, it's being reworked as a core patch. I'd suggest accepting this without a test - because (a) it's a regression and (b) there will be coverage from the pending change.

CRM_Event_Page_EventInfoTest::testFullMessage Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail" #0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail") #1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail") #2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail") #3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail") #4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3)) #5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59)) #6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules() #7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE) #8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE) #9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus() #10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll() #11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts() #12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()

CRM_Event_Page_EventInfoTest::testFullMessage Exception: CRM_Extension_Exception_MissingException: "Failed to find extension: civi_mail" #0 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Container/Basic.php(143): CRM_Extension_Container_Basic->getRelPath("civi_mail") #1 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Extension/Mapper.php(233): CRM_Extension_Container_Basic->getPath("civi_mail") #2 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(261): CRM_Extension_Mapper->keyToBasePath("civi_mail") #3 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Resources.php(311): CRM_Core_Resources->getPath("civi_mail") #4 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(208): CRM_Core_Resources->glob("civi_mail", (Array:3)) #5 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/Civi/Angular/Manager.php(114): Civi\Angular\Manager->resolvePatterns((Array:59)) #6 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component/Env.php(1178): Civi\Angular\Manager->getModules() civicrm#7 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check/Component.php(76): CRM_Utils_Check_Component_Env->checkAngularModuleSettings(FALSE) civicrm#8 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(215): CRM_Utils_Check_Component->checkAll((Array:0), FALSE) civicrm#9 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(185): CRM_Utils_Check::checkStatus() civicrm#10 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Utils/Check.php(93): CRM_Utils_Check::checkAll() civicrm#11 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Core/Page.php(267): CRM_Utils_Check->showPeriodicAlerts() civicrm#12 /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/CRM/Event/Page/EventInfo.php(325): CRM_Core_Page->run()

fix CRM-11995

8f1445e

ghost assigned totten Mar 1, 2013

totten added a commit that referenced this pull request Mar 1, 2013

Merge pull request #9 from dlobo/CRM-11995

fa1a0b4

fix CRM-11995

totten merged commit fa1a0b4 into civicrm:master Mar 1, 2013

atif-shaikh pushed a commit to atif-shaikh/civicrm-core that referenced this pull request Jul 24, 2014

Merge pull request civicrm#9 from dlobo/CRM-12656

5319c3b

CRM-12656

davecivicrm mentioned this pull request Oct 7, 2014

CRM-15372 - Offline Registration w/ Credit Card Saves Processing Fee as Total Amount #4228

Closed

eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Jan 6, 2015

CRM-15680 fix custom data on survey & campaign

bf38705

rohankatkar added a commit to rohankatkar/civicrm-core-master that referenced this pull request Jan 15, 2015

Code cleanup - Batch civicrm#9

7c550ca

monishdeb added a commit that referenced this pull request Jan 15, 2015

Merge pull request #4943 from rohankatkar/batch-9

cd35894

INFRA 32 - Batch #9

deepak-srivastava added a commit to veda-consulting/civicrm-core that referenced this pull request Apr 21, 2015

Merge pull request civicrm#9 from mathavanveda/dedupe-workflow-45-loc

34f243d

select all option in toggleselect

MegaphoneJon pushed a commit to MegaphoneJon/civicrm-core that referenced this pull request Apr 26, 2015

Merge pull request civicrm#9 from ginkgostreet/status-page-1

dca2dad

CRM-13823 Sort status messages by severity, name - even in API

seamuslee001 pushed a commit to seamuslee001/civicrm-core that referenced this pull request Oct 15, 2015

Merge pull request civicrm#9 from seamuslee001/CRM-17402-Fuzion

d587418

CRM-17402 Google Maps API sometimes tries to call initMap callback be…

KarinG mentioned this pull request Jul 15, 2016

CRM-19061 Updated Reports from sprint #8539

Closed

KarinG mentioned this pull request Aug 7, 2016

(WIP) Sybunt - Rob's work #8823

Closed

f2boot pushed a commit to f2boot/civicrm-core that referenced this pull request Sep 25, 2016

Merge pull request civicrm#9 from dlobo/DeleteFile

7d6463b

remove obsolete README

ErichBSchulz pushed a commit to ErichBSchulz/civicrm-core that referenced this pull request Jan 3, 2017

Merged in CRM-17654 (pull request civicrm#9)

554fe76

CRM-17654 Allow for multiple relationship types to be used in the relationship report

mukeshcompucorp pushed a commit to mukeshcompucorp/civicrm-core that referenced this pull request Jan 18, 2018

Merged in PG-344-CiviCRM-Security-Update-4.6.21 (pull request civicrm#9)

8ce4973

PG-344: CiviCRM-4.6.21 update

dsnopek mentioned this pull request Apr 18, 2018

Fix the contact merge form on Drupal 8 #11992

Merged

agilewarealok added a commit to agileware/civicrm-core that referenced this pull request Jun 5, 2018

Accessibility civicrm#9: Regression - js error due to alertDismissal …

a9fb612

…setting fixed.

monishdeb added a commit that referenced this pull request Jun 5, 2018

Merge pull request #12265 from agileware/Accessibility-Issue-9

bc2951c

Accessibility #9: Regression - js error due to alertDismissal setting fixed.

sandrajvillagenetwork mentioned this pull request Aug 20, 2018

CRM-21811: Optimize advanced search by relationship with target g… #11732

Merged

eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Nov 9, 2018

Resolve #9 by purifying label of entity reference values

47bbe89

eileenmcnaughton referenced this pull request in eileenmcnaughton/civicrm-core Jan 16, 2019

Resolve #9 by purifying label of entity reference values

9e295f6

totten pushed a commit that referenced this pull request Feb 21, 2019

Resolve #9 by purifying label of entity reference values

dbf86a7

seamuslee001 added a commit to seamuslee001/civicrm-core that referenced this pull request Feb 22, 2019

Resolve civicrm#9 by purifying label of entity reference values

f39fa31

eileenmcnaughton mentioned this pull request Sep 6, 2020

Test whether line is hit #18382

Closed

colemanw added a commit that referenced this pull request Sep 24, 2020

ext/greenwich - Coerce select2-bootstrap.css to be handled as SCSS (#9

2aba31d

) Co-authored-by: Tim Otten <totten@civicrm.org>

eileenmcnaughton mentioned this pull request Oct 7, 2020

[close on test complete] - find tests that hit memory leaks #18687

Closed

eileenmcnaughton mentioned this pull request Feb 3, 2021

[REF] Extract logical functions from sendTemplate #19510

Merged

eileenmcnaughton mentioned this pull request May 26, 2021

See how many tests fail with this check #20420

Closed

eileenmcnaughton mentioned this pull request Jun 2, 2021

dev/translation#67 - Define "Translation" table. Add during installation/upgrade. #20478

Merged

eileenmcnaughton mentioned this pull request Jun 21, 2021

Deprecate guess work in processPriceSet #20678

Closed

This was referenced Sep 14, 2021

ContributionRecur modified_date should update to current_timestamp on update #21472

Merged

find tests #21534

Closed

eileenmcnaughton mentioned this pull request Jan 12, 2022

Fully deprecate getTokenDetails #22483

Merged

eileenmcnaughton mentioned this pull request Mar 1, 2022

Add handling for civimember disabled #22864

Merged

ginkgomzd mentioned this pull request Apr 26, 2022

correct logic for handling empty-array values for checkboxes; #23305

Merged

eileenmcnaughton mentioned this pull request Feb 18, 2023

Fix test method eventCreatePaid for php 8.2 #25613

Closed

eileenmcnaughton mentioned this pull request Aug 23, 2023

dev/core#2644 Add Scheduled Communications extension #27081

Merged

This was referenced Jan 4, 2024

Add system check to warn if CiviReport disabled & logging enabled #28863

Merged

Logging detail test #28869

Closed

This was referenced Jun 19, 2024

WIP: Fix for https://lab.civicrm.org/dev/core/-/issues/5095 #29736

Closed

Enable message admin by default on new installs #30503

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix CRM-11995 #9

fix CRM-11995 #9

dlobo commented Mar 1, 2013

totten commented Mar 1, 2013

dlobo commented Mar 1, 2013

fix CRM-11995 #9

fix CRM-11995 #9

Conversation

dlobo commented Mar 1, 2013

totten commented Mar 1, 2013

dlobo commented Mar 1, 2013