Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close on test complete] - find tests that hit memory leaks #18687

Closed
wants to merge 3 commits into from

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Oct 7, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

I opened https://lab.civicrm.org/dev/core/-/issues/2097 for the process_mailing leaks

Example test

api_v3_ContactTest::testSortLimitChainedRelationshipGetCRM15983
There are dozens of tests that pass through these lines - I used api_v3_JobTest:testBatchMerge to step through it
- note the dao->affectedRows uses a query to determine that - so it is no more or less accurate than before
@eileenmcnaughton
Copy link
Contributor Author

eileenmcnaughton commented Oct 7, 2020

CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set "basic_data"
CRM_Contact_Import_Form_MapFieldTest.testSubmit with data set "save_mapping"
CRM_Contact_Page_View_UserDashboard_GroupContactTest.testBrowseDisplaysCorrectListOfAddedGroups
CRM_Contact_Page_View_UserDashboard_GroupContactTest.testBrowseDisplaysCorrectListOfAVailableGroups
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentEmptyContact
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributionsWithInvoicingEnabled
CRM_Contact_Page_View_UserDashBoardTest.testDashboardContentContributions
CRM_Import_DataSource_CsvTest.testToCsv with data set #0
CRM_Import_DataSource_CsvTest.testToCsv with data set #1
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #0
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #1
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #2
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #3
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #4
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #5
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #6
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #7
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #8
CRM_Mailing_MailingSystemTest.testUrlTracking with data set #9
CRM_Mailing_MailingSystemTest.testGitLabIssue1108 with data set #0
CRM_Mailing_MailingSystemTest.testGitLabIssue1108 with data set #1
CRM_Mailing_MailingSystemTest.testBasicHeaders
CRM_Mailing_MailingSystemTest.testText
CRM_Mailing_MailingSystemTest.testHtmlWithOpenTracking
CRM_Mailing_MailingSystemTest.testHtmlWithOpenAndUrlTracking
CRM_Mailing_MailingSystemTest.testMailingActivityCreate
CRM_Member_Form_MembershipTest.testSubmitUpdateMembershipFromPartiallyPaid
CRM_Member_Form_MembershipTest.testMembershipViewContributionOwnerDifferent
CRM_Utils_Mail_EmailProcessorTest.testBounceProcessing
CRM_Utils_Mail_EmailProcessorTest.testBounceProcessingInvalidCharacter
CRM_Utils_Mail_EmailProcessorTest.testBounceProcessingUTF8mb4
CRM_Utils_Mail_EmailProcessorTest.testProcessingMultipartRelatedEmail
CRM_Utils_Mail_EmailProcessorTest.testProcessingNestedMultipartEmail
CRM_Utils_Mail_EmailProcessorTest.testBounceProcessingDeletedEmail
api_v3_ContributionTest.testPendingToCompleteContribution
api_v3_JobProcessMailingTest.testConcurrency with data set #0
api_v3_JobProcessMailingTest.testConcurrency with data set #1
api_v3_JobProcessMailingTest.testConcurrency with data set #2
api_v3_JobProcessMailingTest.testConcurrency with data set #3
api_v3_JobProcessMailingTest.testConcurrency with data set #4
api_v3_JobProcessMailingTest.testConcurrency with data set #5
api_v3_JobProcessMailingTest.testConcurrency with data set #6
api_v3_JobProcessMailingTest.testBatchActivityTargets with data set #0
api_v3_JobProcessMailingTest.testBatchActivityTargets with data set #1
api_v3_JobProcessMailingTest.testBasic
api_v3_JobProcessMailingTest.testDecesasedRecepient
api_v3_JobProcessMailingTest.testMultipleBulkRecipients
api_v3_JobProcessMailingTest.testPauseAndResumeMailing
api_v3_JobProcessMailingTest.testMailNonProductionRun
api_v3_LoggingTest.testEnableDisableLogging
api_v3_LoggingTest.testEnableDisableLoggingWithTriggerHook
api_v3_LoggingTest.testEnableLoggingLegacyLogTableExists
api_v3_LoggingTest.testUpdateLegacyLogTable
api_v3_LoggingTest.testCreateMissingLogTables
api_v3_LoggingTest.testUpdateLogTableHookINNODB
api_v3_LoggingTest.testRebuildTriggerAfterSchemaChange
api_v3_LoggingTest.testRevert
api_v3_LoggingTest.testRevertNoDate
api_v3_LoggingTest.testRevertRestrictedTables
api_v3_LoggingTest.testRevertNoDateNotUnique
api_v3_LoggingTest.testGet
api_v3_LoggingTest.testGetNoDate
api_v3_MailingTest.testMailerSendTest_email
api_v3_MailingTest.testMailerSendTest_group
api_v3_MailingTest.testUnsubscribeGroupList
api_v3_MailingTest.testMailerStats
api_v3_MailingTest.testUrlWithMissingTrackingHash
api_v3_MailingTest.testTrackableURLWithUnicodeSign
api_v3_MembershipTest.testMultipleMembershipsContribution
api_v3_SettingTest.testRevertAll
CivicrmUpgradeTest.4_5_0-setupsh_sql_bz2
CivicrmUpgradeTest.4_5_5-setupsh_sql_bz2
CivicrmUpgradeTest.4_6_0-setupsh_sql_bz2
CivicrmUpgradeTest.4_6_11-setupsh_sql_bz2
CivicrmUpgradeTest.4_6_36-setupsh_sql_bz2
CivicrmUpgradeTest.4_7_0-setupsh_sql_bz2
CivicrmUpgradeTest.4_7_31-setupsh_sql_bz2
CivicrmUpgradeTest.5_13_3-multilingual_af_bg_en_mysql_bz2
Civi.FlexMailer.ConcurrentDeliveryTest.testConcurrency with data set #0
Civi.FlexMailer.ConcurrentDeliveryTest.testConcurrency with data set #1
Civi.FlexMailer.ConcurrentDeliveryTest.testConcurrency with data set #2
Civi.FlexMailer.ConcurrentDeliveryTest.testConcurrency with data set #3
Civi.FlexMailer.ConcurrentDeliveryTest.testConcurrency with data set #4
Civi.FlexMailer.ConcurrentDeliveryTest.testConcurrency with data set #5
Civi.FlexMailer.ConcurrentDeliveryTest.testConcurrency with data set #6
Civi.FlexMailer.ConcurrentDeliveryTest.testBatchActivityTargets with data set #0
Civi.FlexMailer.ConcurrentDeliveryTest.testBatchActivityTargets with data set #1
Civi.FlexMailer.ConcurrentDeliveryTest.testBasic
Civi.FlexMailer.ConcurrentDeliveryTest.testDecesasedRecepient
Civi.FlexMailer.ConcurrentDeliveryTest.testMultipleBulkRecipients
Civi.FlexMailer.ConcurrentDeliveryTest.testPauseAndResumeMailing
Civi.FlexMailer.ConcurrentDeliveryTest.testMailNonProductionRun
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #0
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #1
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #2
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #3
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #4
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #5
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #6
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #7
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #8
Civi.FlexMailer.FlexMailerSystemTest.testUrlTracking with data set #9
Civi.FlexMailer.FlexMailerSystemTest.testBasicHeaders
Civi.FlexMailer.FlexMailerSystemTest.testText
Civi.FlexMailer.FlexMailerSystemTest.testHtmlWithOpenTracking
Civi.FlexMailer.FlexMailerSystemTest.testHtmlWithOpenAndUrlTracking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant