Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show HTML source in Storybook #83

Open
AlexSkrypnyk opened this issue Jan 19, 2024 · 2 comments · Fixed by #87
Open

Show HTML source in Storybook #83

AlexSkrypnyk opened this issue Jan 19, 2024 · 2 comments · Fixed by #87
Assignees
@joshua-salsadigital
Labels
BLOCKED Issue or pull request is blocked State: Confirmed The issue was triaged and confirmed for development

Comments

@AlexSkrypnyk
Copy link
Contributor

Several users reported that they would like to see the HTML source of the components in the Storybook.

Solution direction

  1. Add https://github.com/whitespace-se/storybook-addon-html
@AlexSkrypnyk AlexSkrypnyk added the State: Needs triage An issue or PR has not been assessed and requires a triage label Jan 19, 2024
@AlexSkrypnyk
Copy link
Contributor Author

@fionamorrison23
Maybe we can squeeze this into 1.7?

@fionamorrison23 fionamorrison23 added this to the 1.7 milestone Jan 22, 2024
@fionamorrison23 fionamorrison23 added State: Confirmed The issue was triaged and confirmed for development and removed State: Needs triage An issue or PR has not been assessed and requires a triage labels Jan 22, 2024
@fionamorrison23 fionamorrison23 moved this to Todo in UI Kit Jan 22, 2024
@joshua-salsadigital joshua-salsadigital mentioned this issue Jan 25, 2024
Merged
7 tasks
@joshua-salsadigital joshua-salsadigital linked a pull request Jan 25, 2024 that will close this issue
#83 Updated storybook to show HTML source. #87
Merged
7 tasks
AlexSkrypnyk pushed a commit that referenced this issue Jan 26, 2024
@joshua-salsadigital
[#83] Updated storybook to show HTML source. (#87)
92c0b2c 
Co-authored-by: Joshua Fernandes <“joshua.1234511@yahoo.in”>
@github-project-automation github-project-automation bot moved this from Todo to Done in UI Kit Jan 26, 2024
AlexSkrypnyk added a commit that referenced this issue Mar 15, 2024
@AlexSkrypnyk
Revert "[#83] Updated storybook to show HTML source. (#87)"
8909fa9 
This reverts commit 92c0b2c.

# Conflicts:
#	package.json
@AlexSkrypnyk AlexSkrypnyk reopened this Mar 15, 2024
@AlexSkrypnyk AlexSkrypnyk modified the milestones: 1.7, 1.8 Mar 15, 2024
@AlexSkrypnyk
Copy link
Contributor Author

I had to revert this implementation because it requires a patch to be shipped with the UIKit.
We do not support such workflow as this will affect the users making them have a copy of the patch.

This functionality is not critical. It will be implemented in the future UIKIt releases.

@fionamorrison23 fionamorrison23 added the BLOCKED Issue or pull request is blocked label Mar 19, 2024
@fionamorrison23 fionamorrison23 removed this from the 1.8 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshua-salsadigital joshua-salsadigital

Labels
BLOCKED Issue or pull request is blocked State: Confirmed The issue was triaged and confirmed for development
Projects
UI Kit
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#83 Updated storybook to show HTML source. civictheme/uikit
3 participants
@AlexSkrypnyk @joshua-salsadigital @fionamorrison23