Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close stream after property load #42

Merged
merged 1 commit into from
May 29, 2017
Merged

Close stream after property load #42

merged 1 commit into from
May 29, 2017

Conversation

civitz
Copy link
Owner

@civitz civitz commented May 28, 2017 •
edited
Loading

Closes #39

@civitz civitz added the bug label May 28, 2017
@civitz civitz added this to the 0.2 milestone May 28, 2017
@civitz civitz self-assigned this May 28, 2017
n3wtron
n3wtron approved these changes May 29, 2017
View reviewed changes
Copy link
Collaborator

@n3wtron n3wtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@civitz civitz merged commit f61d995 into master May 29, 2017
@civitz civitz deleted the close-stream-after-load branch May 29, 2017 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippobuletto filippobuletto filippobuletto approved these changes

@n3wtron n3wtron n3wtron approved these changes

Assignees

@civitz civitz

Labels
bug
Projects
None yet
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@civitz @n3wtron @filippobuletto