Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Users without XP don't show in Leaderboard #86

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

cjmellor
Copy link
Owner

Description

When running the Leaderboard service, it was also showing Users' without XP, which did not make sense.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Related Issues and Pull Requests

  • Issue #...
  • PR #...

Testing

Please provide a passing test where possible. This package uses PestPHP

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation [OPTIONAL]

@cjmellor cjmellor self-assigned this Jul 13, 2024
@cjmellor cjmellor added the bug Something isn't working label Jul 13, 2024
@cjmellor cjmellor merged commit 1131797 into main Jul 13, 2024
14 checks passed
@cjmellor cjmellor deleted the fix/dont-show-users-without-xp-on-leaderboard branch July 13, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant