-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5452] allow lists in resource extras #5453
Conversation
One more small change was added here. In current versions of ckan dicts passed as resource extras were being stored as their python repr, e.g. |
I think this can be considered a bug fix, the current behaviour is very strange for a JSON API |
@wardi I had to tweak this a bit to adapt it to the old way validators where handled in the schema in 2.7, do you mind having an extra quick look at these to make sure nothing seems off? thanks |
LGTM |
Fixes #5452
Proposed fixes:
remove two lines of code from resource_dict_save. This allows ckanext-scheming and other extensions to have repeating subfields and other list values in their resource schemas without hacks like converting to/from JSON (resource extras are already stored in the DB as JSON)
Features: