Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254-fix-markdown formatting is not translated #8255

Conversation

Nisha1293
Copy link
Contributor

Fixes #8254

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@amercader
Copy link
Member

Thanks @Nisha1293 , the data-bs-* attributes were updated as part of the migration to Bootstrap 5 and sadly we can't revert it. This meant that the string id used in the po files changed, so the library that extracts the strings for translation from the source code considered it was a new string, and the previous translation was lost. Rather than changing the string in the templates (which would break the Bootstrap widgets) we need to update the translation on the po files (actually on Transifex). So you can just copy the old translation from 2.9 and update the data attributes on the 2.10 / 2.11 files:

2.9

#, python-format
msgid ""
"You can use <a href=\"#markdown\" title=\"Markdown quick reference\" data-"
"target=\"popover\" data-content=\"%(markdown_tooltip)s\" data-"
"html=\"true\">Markdown formatting</a> here"
msgstr ""
"ここでは<a href=\"#markdown\" title=\"Markdown quick reference\" data-"
"target=\"popover\" data-content=\"%(markdown_tooltip)s\" data-"
"html=\"true\">Markdown形式</a>を使うことができます "

2.10:

#: ckan/templates/macros/form/markdown.html:31
#, python-format
msgid ""
"You can use <a href=\"#markdown\" title=\"Markdown quick reference\" data-"
"bs-toggle=\"popover\" data-bs-content=\"%(markdown_tooltip)s\" data-bs-"
"html=\"true\">Markdown formatting</a> here"
msgstr ""

Does this make sense?

@Nisha1293
Copy link
Contributor Author

Thanks @amercader for the reply. As per your suggestion, I have updated the translation on transifex for both CKAN v2.10 and v2.11.
Below is the screenshot for the reference.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown formatting is not translated into the selected locale other than English
2 participants