Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organisation field doesn't show selected organisation text #93

Closed
reneenoble opened this issue Oct 14, 2015 · 10 comments
Closed

organisation field doesn't show selected organisation text #93

reneenoble opened this issue Oct 14, 2015 · 10 comments

Comments

@reneenoble
Copy link

Hi I'm using ckan 2.4 just trying to display the ckan_dataset schema provided in the package.

When I go to select an organisation from the drop down (or there an organisation already selected as I have started making a dataset within the organisation) the selected organisation doesn't show up in the box. It is definitely selected, as can be seen in the developer tools (where the selected option updates) and the dataset can be create and shows up under the correct organisation. But the text just isn't showing up, it just remains blank.

Thanks,
Renee

@wardi
Copy link
Contributor

wardi commented Oct 15, 2015

I'm not sure I understand, is this a UI-only issue? Would you send a screenshot?

@reneenoble
Copy link
Author

Hi Ian,

Yeah I think some javascript is broken for the manage dataset interface. I'd try and fix it but javascript is not my forte.

Ok a screen shot is attached that shows what it looks like after I have clicked on an an organisation from the drop down list. You can see I've selected "test1" as the organisation in the developer tools on the right, but the field box where it should display is empty.

To check it out yourself go here: http://52.64.153.184/dataset/edit/second-title
and log in with
username: help
password: pass

Then look at the field for organisation and select an organisation. It won't display the name you select. But you can tell it's been selected in the developer tools.

This also occurs when you have more organisations available in the drop down menu, you can see the field update in the dev tools if you click different options, but still no text appears in the box.

I should note that you are still able to create the dataset because it is technically selected. It's just the display that's broken.

Thanks a bundle!
Renee


From: Ian Ward notifications@github.com
Sent: Thursday, 15 October 2015 11:01 PM
To: open-data/ckanext-scheming
Cc: Renee Louise Noble
Subject: Re: [ckanext-scheming] organisation field doesn't show selected organisation text (#93)

I'm not sure I understand, is this a UI-only issue? Would you send a screenshot?

Reply to this email directly or view it on GitHubhttps://github.com//issues/93#issuecomment-148366172.

[https://avatars0.githubusercontent.com/u/7269759?v=3&s=400]#93 (comment)

organisation field doesn't show selected organisation text · Issue #93 · open-data/ckanext-scheming
Hi I'm using ckan 2.4 just trying to display the ckan_dataset schema provided in the package. When I go to select an organisation from the drop down (or there an organisation already selected as...
Read more...#93 (comment)

@reneenoble
Copy link
Author

Let me know if there is any other info I can provide.

Thanks!

@wardi
Copy link
Contributor

wardi commented Oct 20, 2015

Do you mind comparing the html/JS generated with scheming vs. without to try to see why scheming is not working on 2.4?

@hkotkanen
Copy link

+1, experiencing the same issue.

Haven't looked into it very far, but I did find that it's caused by styling: the input-prepend class has font-size: 0 (see screenshot and sorry it's in Finnish). Overriding the font-size to something sensible fixes the problem, but I don't know how to fix it in the source.

It looks like the class was introduced in commit 9957fa0.
organization_fontsize_0

@wardi
Copy link
Contributor

wardi commented Oct 20, 2015

Why don't we just remove the class from the snippet? I was copying that class from the form macro, but I must have done it wrong.

@reneenoble
Copy link
Author

Yeah can confirm fixed with forcing the font size to change in dev tools.

Works once I remove the class too, so I'll go with that.

Thanks!

@wardi
Copy link
Contributor

wardi commented Oct 21, 2015

Ok, please confirm that b5294e0 fixes this issue

@reneenoble
Copy link
Author

Yep that's the fix I made.

Just re-cloned the repo and that works. :)

@hkotkanen
Copy link

Great thanks, issue fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants