Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scheming command to allow dataset_fields key. #81

Merged
merged 3 commits into from
Sep 4, 2015
Merged

Conversation

brew
Copy link
Member

@brew brew commented Sep 3, 2015

Group and Org schemas use fields as the key to the array within the
schema json file. Dataset schemas use dataset_fields. This commit
stops the scheming command from breaking when printing dataset fields.

Group and Org schemas use `fields` as the key to the array within the
schema json file. Dataset schemas use `dataset_fields`. This commit
stops the `scheming` command from breaking when printing dataset fields.
@brew
Copy link
Member Author

brew commented Sep 3, 2015

Go on then ;)

@wardi
Copy link
Contributor

wardi commented Sep 3, 2015

If I'm reading this correctly this will separate the resource fields from their corresponding dataset fields when multiple dataset schemas are enabled. That might be confusing. Can you instead list the resource fields right after the dataset fields for a given schema?

@brew
Copy link
Member Author

brew commented Sep 3, 2015

It treats the resource schema like a separate schema. The output is after datasets, like this:

Dataset schemas:
 * "dataset"
   - "fluent_title"
   - "name"
   - ...

Resource schemas:
 * "resource"
   - "url"
   - "fluent_name"
   - "fluent_description"
   - "format"

Group schemas:
 * "group"
   - "title"
   - "name"
   - "notes"
   - "url"
   - "bookface"

Organization schemas:
    plugin not loaded or schema not specified

But, yes, we could have it so resources appear with "dataset" like this:

Dataset schemas:
 * "dataset"
   - "fluent_title"
   - "name"
   - ...

 * "resource"
   - "url"
   - "fluent_name"
   - "fluent_description"
   - "format"
...

wardi added a commit that referenced this pull request Sep 4, 2015
Fix `scheming` command to allow dataset_fields key.
@wardi wardi merged commit dea3ca4 into ckan:master Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants