Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): upgrade elliptic #347

Merged
merged 2 commits into from
Sep 10, 2019
Merged

chore(deps): upgrade elliptic #347

merged 2 commits into from
Sep 10, 2019

Conversation

Keith-CY
Copy link
Member

No description provided.

@Keith-CY Keith-CY marked this pull request as ready for review September 10, 2019 01:46
@codecov-io
Copy link

codecov-io commented Sep 10, 2019

Codecov Report

Merging #347 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #347   +/-   ##
========================================
  Coverage    98.18%   98.18%           
========================================
  Files           12       12           
  Lines          497      497           
  Branches       141      141           
========================================
  Hits           488      488           
  Misses           5        5           
  Partials         4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc80de...867e80f. Read the comment docs.

Copy link
Contributor

@ashchan ashchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to this but worthy some research. Elliptic depends on BN.js 4.4, which doesn't have updated @types/bn.js yet. We tried to upgrade BN for Neuron but lack of new @types/bn.js has stopped me. Is there any way to get or generate a new copy of BN types? (I even wanted to upgrade to BN 5)

@Keith-CY
Copy link
Member Author

Not directly related to this but worthy some research. Elliptic depends on BN.js 4.4, which doesn't have updated @types/bn.js yet. We tried to upgrade BN for Neuron but lack of new @types/bn.js has stopped me. Is there any way to get or generate a new copy of BN types? (I even wanted to upgrade to BN 5)

We can submit a PR to the DefinitelyTypes to update the type definition.

@Keith-CY
Copy link
Member Author

Not directly related to this but worthy some research. Elliptic depends on BN.js 4.4, which doesn't have updated @types/bn.js yet. We tried to upgrade BN for Neuron but lack of new @types/bn.js has stopped me. Is there any way to get or generate a new copy of BN types? (I even wanted to upgrade to BN 5)

If only the type definition is required, simply copy the current version and put it in the types directory and update the outdated interface.

@ashchan
Copy link
Contributor

ashchan commented Sep 10, 2019

Not directly related to this but worthy some research. Elliptic depends on BN.js 4.4, which doesn't have updated @types/bn.js yet. We tried to upgrade BN for Neuron but lack of new @types/bn.js has stopped me. Is there any way to get or generate a new copy of BN types? (I even wanted to upgrade to BN 5)

If only the type definition is required, simply copy the current version and put it in the types directory and update the outdated interface.

Looks good enough. Looking at @types issues I don't think a PR would get merged very soon.

@ashchan ashchan merged commit 996a67e into develop Sep 10, 2019
@Keith-CY Keith-CY deleted the upgrade-elliptic branch September 10, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants