-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade elliptic #347
Conversation
Snyk have raised this PR to upgrade elliptic from 6.4.1 to 6.5.0. See this package in NPM: https://www.npmjs.com/package/elliptic See this project in Snyk: https://app.snyk.io/org/keith-cy/project/5fe1e9d5-d05e-40ee-bc0e-a7bf0f348d3a?utm_source=github&utm_medium=upgrade-pr
Codecov Report
@@ Coverage Diff @@
## develop #347 +/- ##
========================================
Coverage 98.18% 98.18%
========================================
Files 12 12
Lines 497 497
Branches 141 141
========================================
Hits 488 488
Misses 5 5
Partials 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related to this but worthy some research. Elliptic depends on BN.js 4.4, which doesn't have updated @types/bn.js yet. We tried to upgrade BN for Neuron but lack of new @types/bn.js has stopped me. Is there any way to get or generate a new copy of BN types? (I even wanted to upgrade to BN 5)
We can submit a PR to the DefinitelyTypes to update the type definition. |
If only the type definition is required, simply copy the current version and put it in the |
Looks good enough. Looking at |
No description provided.