Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): enable batch request #449

Merged
merged 4 commits into from
Jul 2, 2020
Merged

feat(rpc): enable batch request #449

merged 4 commits into from
Jul 2, 2020

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Jul 1, 2020

  1. Add an API for batch request
  2. Remove the method property from class CKBRPC

BREAKING CHANGE: 1. Add an API for batch request

re #438

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #449 into develop will decrease coverage by 0.07%.
The diff coverage is 55.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #449      +/-   ##
===========================================
- Coverage    90.77%   90.69%   -0.08%     
===========================================
  Files           29       28       -1     
  Lines         1181     1171      -10     
  Branches       273      273              
===========================================
- Hits          1072     1062      -10     
  Misses         108      108              
  Partials         1        1              
Impacted Files Coverage Δ
packages/ckb-sdk-rpc/src/method.ts 47.82% <50.00%> (+7.82%) ⬆️
packages/ckb-sdk-rpc/src/Base.ts 100.00% <100.00%> (ø)
packages/ckb-sdk-rpc/src/resultFormatter.ts 100.00% <0.00%> (+0.85%) ⬆️
packages/ckb-sdk-core/src/signWitnessGroup.ts 100.00% <0.00%> (+8.00%) ⬆️

@Keith-CY Keith-CY force-pushed the batch-request branch 2 times, most recently from bf2899d to 6eeb124 Compare July 1, 2020 18:00
1. Add an API for batch request
2. Remove the method property from class CKBRPC

BREAKING CHANGE: 1. Add an API for batch request

re #438
It's tested but not recognized by codecov
improve overall range and reduce weight of patch
@Keith-CY Keith-CY marked this pull request as ready for review July 1, 2020 19:17
@Keith-CY Keith-CY merged commit 9517cae into develop Jul 2, 2020
@Keith-CY Keith-CY deleted the batch-request branch July 2, 2020 05:50
@Keith-CY Keith-CY mentioned this pull request Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants