Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Versions in lock file are not bumped correctly #389

Closed
Keith-CY opened this issue Jul 21, 2023 · 1 comment
Closed

Versions in lock file are not bumped correctly #389

Keith-CY opened this issue Jul 21, 2023 · 1 comment
Assignees
@Keith-CY
Labels
bug Something isn't working

Comments

@Keith-CY
Copy link
Member

The workaround for incompatibility between lerna@7 and npm@9 prevents package-lock.json from being updated correctly

Ref: 05a5fe0
@Keith-CY Keith-CY added the bug Something isn't working label Jul 21, 2023
@Keith-CY Keith-CY self-assigned this Jul 21, 2023
Keith-CY added a commit that referenced this issue Jul 27, 2023
@Keith-CY
ci: remove workaround for incompatibility between lerna@7 and npm@9
46a9856 
Lerna cannot bump versions due to incompatibility of the lock
file, so it was ignored during the version bumping.

This workaround introduced a bug mentioned at #389

Now I've tried to bump versions without ignoring the lock file
and it works, so the workaround is simply removed by this commit.

Ref: lerna/lerna#3418 (comment)
@Keith-CY Keith-CY mentioned this issue Jul 27, 2023
Merged
@Keith-CY
Copy link
Member Author

Should be fixed by #398

github-merge-queue bot pushed a commit that referenced this issue Jul 28, 2023
@Keith-CY
ci: remove workaround for incompatibility between lerna@7 and npm@9 (#…
6820b80 
…398)

Lerna cannot bump versions due to incompatibility of the lock
file, so it was ignored during the version bumping.

This workaround introduced a bug mentioned at #389

Now I've tried to bump versions without ignoring the lock file
and it works, so the workaround is simply removed by this commit.

Ref: lerna/lerna#3418 (comment)
@Keith-CY Keith-CY closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keith-CY Keith-CY

Labels
bug Something isn't working
Projects
CKB JS Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Keith-CY