Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add coverage action #210

Merged
merged 2 commits into from
May 10, 2023
Merged

feat: add coverage action #210

merged 2 commits into from
May 10, 2023

Conversation

PainterPuppets
Copy link
Contributor

@PainterPuppets PainterPuppets commented Mar 29, 2023 •
edited
Loading

  • support coverage action

#200

@Keith-CY Keith-CY mentioned this pull request Mar 29, 2023
Closed
@Keith-CY
Copy link
Member

Keith-CY commented Apr 7, 2023

CI failed

@Keith-CY
Copy link
Member

How is it going

1 similar comment
@Keith-CY
Copy link
Member

How is it going

@Keith-CY
Copy link
Member

The action has been executed at https://github.com/ckb-js/kuai/actions/runs/4930573627/jobs/8811640162 and the report can be found at https://app.codecov.io/github/ckb-js/kuai/commit/2181467b024c762ad551c2f310054598f0be2b84

Can we set the report be attached in the PR automatically?

@Keith-CY
Copy link
Member

What if exclude tests in packages/samples from the coverage

@PainterPuppets
Copy link
Contributor Author

The action has been executed at https://github.com/ckb-js/kuai/actions/runs/4930573627/jobs/8811640162 and the report can be found at https://app.codecov.io/github/ckb-js/kuai/commit/2181467b024c762ad551c2f310054598f0be2b84

Can we set the report be attached in the PR automatically?

Ok, I'll see how to do it

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@01ec626). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #210   +/-   ##
==========================================
  Coverage           ?   70.89%           
==========================================
  Files              ?       79           
  Lines              ?     2168           
  Branches           ?      495           
==========================================
  Hits               ?     1537           
  Misses             ?      571           
  Partials           ?       60

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01ec626...a30b51a. Read the comment docs.

@Keith-CY Keith-CY merged commit 106547b into develop May 10, 2023
@Keith-CY Keith-CY deleted the add_coverage_action branch May 10, 2023 15:44
This was referenced Jul 21, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanguoyu yanguoyu yanguoyu approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@Daryl-L Daryl-L Awaiting requested review from Daryl-L

@zhengjianhui zhengjianhui Awaiting requested review from zhengjianhui

Assignees

@PainterPuppets PainterPuppets

Labels
None yet
Projects
CKB JS Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PainterPuppets @Keith-CY @codecov-commenter @yanguoyu