Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add contract upgrade cli #341

Merged
merged 2 commits into from
Jul 13, 2023
Merged

feat: add contract upgrade cli #341

merged 2 commits into from
Jul 13, 2023

Conversation

PainterPuppets
Copy link
Contributor

@PainterPuppets PainterPuppets commented Jun 28, 2023

Usage: kuai contract upgrade [options]

Options:
  --name [string]            name of the contract to be deployed (default: "")
  --bin-path [path]          path of contract bin file (default: "")
  --migration-path <string>  path of migration file
  --feepayer <string...>     address or multisig config of the transaction fee payer
                             (default: "")
  --deployer <string...>     address or multisig config of the contract deployer
                             (default: "")
  --signer [string]          signer provider [default: ckb-cli] [possible values:
                             ckb-cli, ckb-cli-multisig] (default: "")
  --fee-rate [number]        per transaction's fee, deployment may involve more than
                             one transaction. default: [1000] shannons/Byte
                             (default: 1000)
  --export [path]            export transaction to file (default: "")
  --send                     send transaction directly (default: false)

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023

Codecov Report

Merging #341 (e5c5987) into develop (7701193) will decrease coverage by 3.26%.
The diff coverage is 8.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #341      +/-   ##
===========================================
- Coverage    64.19%   60.93%   -3.26%     
===========================================
  Files           93       95       +2     
  Lines         2924     3259     +335     
  Branches       631      759     +128     
===========================================
+ Hits          1877     1986     +109     
- Misses         949     1155     +206     
- Partials        98      118      +20     
Impacted Files Coverage Δ
packages/core/src/errors-list.ts 100.00% <ø> (ø)
packages/core/src/builtin-tasks/contract.ts 14.61% <4.61%> (-5.92%) ⬇️
packages/core/src/contract.ts 10.90% <7.40%> (-7.85%) ⬇️
packages/core/src/util/contract-migration.ts 28.57% <28.57%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7701193...e5c5987. Read the comment docs.

packages/core/src/builtin-tasks/contract.ts Outdated Show resolved Hide resolved
packages/core/src/builtin-tasks/contract.ts Outdated Show resolved Hide resolved
packages/core/src/builtin-tasks/contract.ts Outdated Show resolved Hide resolved
packages/core/src/builtin-tasks/contract.ts Outdated Show resolved Hide resolved
packages/core/src/builtin-tasks/contract.ts Outdated Show resolved Hide resolved
packages/core/src/builtin-tasks/contract.ts Show resolved Hide resolved
packages/core/src/contract.ts Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

Any update for the conversations?

@Keith-CY Keith-CY mentioned this pull request Jul 11, 2023
@Keith-CY Keith-CY merged commit 5a284c4 into develop Jul 13, 2023
@Keith-CY Keith-CY deleted the add_contract_upgrade_cli branch July 13, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants