Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add test cases for moleculec command. #363

Merged
merged 1 commit into from
Jul 17, 2023
Merged

chore: Add test cases for moleculec command. #363

merged 1 commit into from
Jul 17, 2023

Conversation

yanguoyu
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023 •
edited
Loading

Codecov Report

Merging #363 (ef6fe76) into develop (5a284c4) will increase coverage by 1.35%.
The diff coverage is 100.00%.

❗ Current head ef6fe76 differs from pull request most recent head b71fe00. Consider uploading reports for the commit b71fe00 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #363      +/-   ##
===========================================
+ Coverage    61.04%   62.39%   +1.35%     
===========================================
  Files           94       94              
  Lines         3101     3101              
  Branches       688      688              
===========================================
+ Hits          1893     1935      +42     
+ Misses        1095     1057      -38     
+ Partials       113      109       -4
Impacted Files Coverage Δ
packages/core/src/builtin-tasks/moleculec.ts 62.76% <100.00%> (+44.68%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a284c4...b71fe00. Read the comment docs.

@yanguoyu yanguoyu requested a review from homura July 14, 2023 01:04
homura
homura approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanguoyu yanguoyu added this pull request to the merge queue Jul 17, 2023
Merged via the queue into ckb-js:develop with commit 49c01fc Jul 17, 2023
@yanguoyu yanguoyu deleted the testcase-molecule branch July 17, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@homura homura homura approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@Daryl-L Daryl-L Daryl-L approved these changes

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yanguoyu @codecov-commenter @Daryl-L @Keith-CY @homura