Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ckb-indexer): integrate merged rpc #445

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

PainterPuppets
Copy link
Contributor

@PainterPuppets PainterPuppets commented Oct 13, 2022

Description

  • update @ckb-lumos/ckb-indexer to support merged indexer

Resolved: #416

This is a no breaking change PR

With the merged indexer, we no longer need to depend on a separate ckb-indexer

import { Indexer } from '@ckb-lumos/lumos';

// before
// const indexer = new Indexer(
//   "https://testnet.ckb.dev/indexer", 
//   "https://testnet.ckb.dev/rpc",
// );

// after
const indexer = new Indexer("https://testnet.ckb.dev/rpc");

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation or Website
  • Example
  • Other

How Has This Been Tested?

  • pass e2e test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules -->

@vercel
Copy link

vercel bot commented Oct 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lumos-website ✅ Ready (Inspect) Visit Preview Oct 14, 2022 at 8:13AM (UTC)

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #445 (1ce2fe3) into develop (5f1a8c4) will increase coverage by 0.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #445      +/-   ##
===========================================
+ Coverage    82.55%   82.58%   +0.02%     
===========================================
  Files           98       98              
  Lines        20198    20227      +29     
  Branches      1934     1935       +1     
===========================================
+ Hits         16675    16705      +30     
+ Misses        3469     3468       -1     
  Partials        54       54              
Impacted Files Coverage Δ
packages/ckb-indexer/src/indexer.ts 29.72% <68.18%> (+2.23%) ⬆️
packages/ckb-indexer/src/type.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f1a8c4...1ce2fe3. Read the comment docs.

Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@homura homura merged commit 5bfcd31 into ckb-js:develop Oct 19, 2022
homura pushed a commit to homura/lumos that referenced this pull request Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate new ckb + ckb-indexer
2 participants