Skip to content

Commit 95b8f98

Browse files
committed
Merge branch 't/9599'
2 parents cfab36d + 4aa6388 commit 95b8f98

File tree

3 files changed

+20
-36
lines changed

3 files changed

+20
-36
lines changed

plugins/magicline/dev/magicline.html

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -582,8 +582,7 @@ <h2>Enter mode: BR</h2>
582582
CKEDITOR.replace( 'editor4' );
583583

584584
CKEDITOR.replace( 'hood', {
585-
magicline_color: 'green',
586-
magicline_opacity: .3
585+
magicline_color: 'green'
587586
});
588587

589588
CKEDITOR.replace( 'editor5', {

plugins/magicline/plugin.js

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -708,8 +708,6 @@
708708
// Make the box unselectable.
709709
line.unselectable();
710710

711-
line.setOpacity( that.editor.config.magicline_opacity || 1 );
712-
713711
// Handle accessSpace node insertion.
714712
line.lineChildren[ 0 ].on( 'mouseup', function( event ) {
715713
line.detach();
@@ -1518,24 +1516,24 @@
15181516
* causes the box to appear. The distance is expressed in pixels (px).
15191517
*
15201518
* // Increases the offset to 15px.
1521-
* CKEDITOR.config.line_triggerOffset = 15;
1519+
* CKEDITOR.config.magicline_triggerOffset = 15;
15221520
*
1523-
* @cfg {Number} [line_triggerOffset=30]
1521+
* @cfg {Number} [magicline_triggerOffset=30]
15241522
* @member CKEDITOR.config
1525-
* @see CKEDITOR.config#line_holdDistance
1523+
* @see CKEDITOR.config#magicline_holdDistance
15261524
*/
15271525

15281526
/**
15291527
* Defines the distance between mouse pointer and the box, within
15301528
* which the box stays revealed and no other focus space is offered to be accessed.
1531-
* The value is relative to {@link #line_triggerOffset}.
1529+
* The value is relative to {@link #magicline_triggerOffset}.
15321530
*
1533-
* // Increases the distance to 80% of CKEDITOR.config.line_triggerOffset.
1534-
* CKEDITOR.config.line_holdDistance = .8;
1531+
* // Increases the distance to 80% of CKEDITOR.config.magicline_triggerOffset.
1532+
* CKEDITOR.config.magicline_holdDistance = .8;
15351533
*
1536-
* @cfg {Number} [line_holdDistance=0.5]
1534+
* @cfg {Number} [magicline_holdDistance=0.5]
15371535
* @member CKEDITOR.config
1538-
* @see CKEDITOR.config#line_triggerOffset
1536+
* @see CKEDITOR.config#magicline_triggerOffset
15391537
*/
15401538

15411539
// %REMOVE_START%
@@ -1545,10 +1543,10 @@
15451543
* holds start of the current selection or just simply holds the caret.
15461544
*
15471545
* // Changes keystroke to CTRL + SHIFT + ,
1548-
* CKEDITOR.config.line_keystrokeBefore = CKEDITOR.CTRL + CKEDITOR.SHIFT + 188;
1546+
* CKEDITOR.config.magicline_keystrokeBefore = CKEDITOR.CTRL + CKEDITOR.SHIFT + 188;
15491547
*
15501548
* @ignore
1551-
* @cfg {Number} [line_keystrokeBefore=CKEDITOR.CTRL + CKEDITOR.SHIFT + 219 (CTRL + SHIFT + [)]
1549+
* @cfg {Number} [magicline_keystrokeBefore=CKEDITOR.CTRL + CKEDITOR.SHIFT + 219 (CTRL + SHIFT + [)]
15521550
* @member CKEDITOR.config
15531551
*/
15541552
// CKEDITOR.config.magicline_keystrokeBefore = CKEDITOR.CTRL + CKEDITOR.SHIFT + 219; // CTRL + SHIFT + [
@@ -1558,10 +1556,10 @@
15581556
* holds start of the current selection or just simply holds the caret.
15591557
*
15601558
* // Changes keystroke to CTRL + SHIFT + .
1561-
* CKEDITOR.config.line_keystrokeBefore = CKEDITOR.CTRL + CKEDITOR.SHIFT + 190;
1559+
* CKEDITOR.config.magicline_keystrokeBefore = CKEDITOR.CTRL + CKEDITOR.SHIFT + 190;
15621560
*
15631561
* @ignore
1564-
* @cfg {Number} [line_keystrokeBefore=CKEDITOR.CTRL + CKEDITOR.SHIFT + 221 (CTRK + SHIFT + ])]
1562+
* @cfg {Number} [magicline_keystrokeBefore=CKEDITOR.CTRL + CKEDITOR.SHIFT + 221 (CTRK + SHIFT + ])]
15651563
* @member CKEDITOR.config
15661564
*/
15671565
// CKEDITOR.config.magicline_keystrokeAfter = CKEDITOR.CTRL + CKEDITOR.SHIFT + 221; // CTRL + SHIFT + ]
@@ -1572,20 +1570,9 @@
15721570
* Defines box color. The color may be adjusted to enhance readability.
15731571
*
15741572
* // Changes color to blue.
1575-
* CKEDITOR.config.line_boxColor = '#0000FF';
1576-
*
1577-
* @cfg {String} [line_boxColor='#FF0000']
1578-
* @member CKEDITOR.config
1579-
*/
1580-
1581-
/**
1582-
* Defines box opacity. The opacity may be adjusted to enhance readability
1583-
* by revealing underlying elements.
1584-
*
1585-
* // Changes opacity to 30%.
1586-
* CKEDITOR.config.line_boxOpacity = .3;
1573+
* CKEDITOR.config.magicline_color = '#0000FF';
15871574
*
1588-
* @cfg {Number} [line_boxOpacity=1]
1575+
* @cfg {String} [magicline_color='#FF0000']
15891576
* @member CKEDITOR.config
15901577
*/
15911578

@@ -1594,8 +1581,8 @@
15941581
* {@link CKEDITOR.dtd#$block} elements as accessible by the box.
15951582
*
15961583
* // Enables "put everywhere" mode.
1597-
* CKEDITOR.config.line_putEverywhere = true;
1584+
* CKEDITOR.config.magicline_putEverywhere = true;
15981585
*
1599-
* @cfg {Boolean} [line_putEverywhere=false]
1586+
* @cfg {Boolean} [magicline_putEverywhere=false]
16001587
* @member CKEDITOR.config
16011588
*/

plugins/magicline/samples/magicline.html

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,11 @@ <h1 class="samples">
113113
</label>
114114
<div class="description">
115115
<p>
116-
This editor is using a blue line with slight opacity.
116+
This editor is using a blue line.
117117
</p>
118118
<pre class="samples">
119119
CKEDITOR.replace( 'editor2', {
120-
magicline_color: 'blue',
121-
magicline_opacity: .8
120+
magicline_color: 'blue'
122121
});</pre>
123122
</div>
124123
<textarea cols="80" id="editor2" name="editor2" rows="10">
@@ -182,8 +181,7 @@ <h1 class="samples">
182181
// window.onload event handler.
183182

184183
CKEDITOR.replace( 'editor2', {
185-
magicline_color: 'blue', // Blue line
186-
magicline_opacity: .5
184+
magicline_color: 'blue' // Blue line
187185
});
188186

189187
</script>

0 commit comments

Comments
 (0)